Skip to content

[BUG] Fix dsa_sparse_finetune/sparse_mla_bwd.py bug #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeiWang1999 merged 2 commits into from
Jan 18, 2026
Merged

[BUG] Fix dsa_sparse_finetune/sparse_mla_bwd.py bug #1588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fbbed1
update
xiuhu17 Dec 31, 2025
de3d980
Merge branch 'tile-ai:main' into dev_
xiuhu17 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions examples/dsa_sparse_finetune/sparse_mla_bwd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,17 +226,17 @@ def sparse_mla_bwd_kernel(
if bi_i < BS // split_store:
acc_dkv_tail_shared[bi_i, d_i] = acc_dkv_tail[bi_i + s * (BS // split_store), d_i]

for bi_i, d_i in T.Parallel(BS // split_store, D // 4):
T.atomic_addx4(
dKV[bos + Indices[bos + s_i, bz, i_i * BS + bi_i + s * (BS // split_store)], bz, d_i * 4],
acc_dkv_shared[bi_i, d_i * 4],
for bi_i, d_i in T.Parallel(BS // split_store, D):
T.atomic_add(
dKV[bos + Indices[bos + s_i, bz, i_i * BS + bi_i + s * (BS // split_store)], bz, d_i],
acc_dkv_shared[bi_i, d_i],
)

# Atomically update dKV, dKV_tail tensors
for bi_i, d_i in T.Parallel(BS // split_store, D_tail // 4):
T.atomic_addx4(
dKV[bos + Indices[bos + s_i, bz, i_i * BS + bi_i + s * (BS // split_store)], bz, D + d_i * 4],
acc_dkv_tail_shared[bi_i, d_i * 4],
for bi_i, d_i in T.Parallel(BS // split_store, D_tail):
T.atomic_add(
dKV[bos + Indices[bos + s_i, bz, i_i * BS + bi_i + s * (BS // split_store)], bz, D + d_i],
acc_dkv_tail_shared[bi_i, d_i],
)

# Store the accumulated dQ
Expand Down