Skip to content

Conversation

@xwhzz
Copy link
Contributor

@xwhzz xwhzz commented Dec 29, 2025

Updated the conditions for the performance regression test job.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD regression testing workflow to optimize job execution logic and permission checks.

✏️ Tip: You can customize this high-level summary in your review settings.

Updated the conditions for the performance regression test job.
@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

📝 Walkthrough

Walkthrough

Reorganized GitHub Actions workflow gate logic by moving the conditional check from the pr-regression job to the permissions-check job. The gating condition restricts execution to repository owner tile-ai, issue PR events, and PR comments containing @regression-perf.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Gate Refactoring
\.github/workflows/pr-regression-test-bot\.yml
Relocated conditional execution logic from pr-regression job to permissions-check job. The gate now evaluates repository owner, event type (issue PR), and PR comment content (@regression-perf) at the permissions-check stage, allowing pr-regression to run unconditionally after permissions validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • LeiWang1999

Poem

🐰 A hop, a skip, through workflow gates we go,
Permissions checked before the show,
Regression tests in proper queue,
Gated wisely—much smoother too! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: refactoring the conditional logic in the PR regression test job by moving the gate condition from pr-regression to permissions-check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4ad7d3 and 6792dea.

📒 Files selected for processing (1)
  • .github/workflows/pr-regression-test-bot.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: XuehaiPan
Repo: tile-ai/tilelang PR: 973
File: .github/workflows/ci.yml:13-15
Timestamp: 2025-10-10T13:29:29.347Z
Learning: In .github/workflows/ci.yml for tilelang (GitHub Actions), actions/cachev4 and setup-python’s cache feature require GITHUB_TOKEN with actions: write to save caches; with a permissions block that only sets contents: read, unspecified actions permission becomes none, so caches will restore but not save.
📚 Learning: 2025-10-10T13:29:29.347Z
Learnt from: XuehaiPan
Repo: tile-ai/tilelang PR: 973
File: .github/workflows/ci.yml:13-15
Timestamp: 2025-10-10T13:29:29.347Z
Learning: In .github/workflows/ci.yml for tilelang (GitHub Actions), actions/cachev4 and setup-python’s cache feature require GITHUB_TOKEN with actions: write to save caches; with a permissions block that only sets contents: read, unspecified actions permission becomes none, so caches will restore but not save.

Applied to files:

  • .github/workflows/pr-regression-test-bot.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
🔇 Additional comments (1)
.github/workflows/pr-regression-test-bot.yml (1)

36-39: LGTM! Clean refactoring of the gate condition.

Moving the conditional check to the permissions-check job is more efficient and clearer. Since pr-regression depends on permissions-check via the needs clause, the workflow will correctly skip both jobs when the condition isn't met, avoiding unnecessary execution.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/pr-regression-test-bot.yml (1)

8-11: Add actions: write to permissions block for cache saving.

The permissions block (lines 8-11) does not include actions: write. The workflow uses astral-sh/setup-uv@v7 with enable-cache: true (line 159) for GitHub-hosted runners, which requires actions: write permission to save caches to GitHub Actions cache. Without it, caches will restore but fail to save, significantly reducing build performance.

Add actions: write to the permissions block:

permissions:
  actions: write
  contents: read
  issues: write
  pull-requests: write
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4ad7d3 and 6792dea.

📒 Files selected for processing (1)
  • .github/workflows/pr-regression-test-bot.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: XuehaiPan
Repo: tile-ai/tilelang PR: 973
File: .github/workflows/ci.yml:13-15
Timestamp: 2025-10-10T13:29:29.347Z
Learning: In .github/workflows/ci.yml for tilelang (GitHub Actions), actions/cachev4 and setup-python’s cache feature require GITHUB_TOKEN with actions: write to save caches; with a permissions block that only sets contents: read, unspecified actions permission becomes none, so caches will restore but not save.
📚 Learning: 2025-10-10T13:29:29.347Z
Learnt from: XuehaiPan
Repo: tile-ai/tilelang PR: 973
File: .github/workflows/ci.yml:13-15
Timestamp: 2025-10-10T13:29:29.347Z
Learning: In .github/workflows/ci.yml for tilelang (GitHub Actions), actions/cachev4 and setup-python’s cache feature require GITHUB_TOKEN with actions: write to save caches; with a permissions block that only sets contents: read, unspecified actions permission becomes none, so caches will restore but not save.

Applied to files:

  • .github/workflows/pr-regression-test-bot.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
🔇 Additional comments (1)
.github/workflows/pr-regression-test-bot.yml (1)

36-39: LGTM! Clean refactoring of the gate condition.

Moving the conditional check to the permissions-check job is more efficient and clearer. Since pr-regression depends on permissions-check via the needs clause, the workflow will correctly skip both jobs when the condition isn't met, avoiding unnecessary execution.

@LeiWang1999 LeiWang1999 merged commit 8c9101e into tile-ai:main Dec 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants