Skip to content

[Bugfix] Fallback to a Linear Layout instead of raising errors #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeiWang1999 merged 2 commits into from
Dec 24, 2025
Merged

[Bugfix] Fallback to a Linear Layout instead of raising errors #1521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b55961
Enhance GEMM layout functions to include a fallback for float64 when …
LeiWang1999 Dec 24, 2025
44eeb56
lint fix
LeiWang1999 Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions src/layout/gemm_layouts.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,19 +757,28 @@ Layout makeGemmABLayoutHopper(int mat_stride, int mat_continuous,
return makeGemmABLayoutF64_Kouter(mat_stride, mat_continuous);
if (k_inner && continuity % 16 == 0) // float64 NxK
return makeGemmABLayoutF64_Kinner(mat_stride, mat_continuous);
// fallback for float64 when stride % 8 != 0
if (mat_stride % 8 != 0)
return makeLinearLayout(
Array<PrimExpr>{Integer(mat_stride), Integer(mat_continuous)});
return makeQuarterBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
}
int vector_size = 128 / element_size;

if (mat_continuous % (vector_size * 8) == 0)
return makeFullBankSwizzleLayout(mat_stride, mat_continuous, element_size);
else if (mat_continuous % (vector_size * 4) == 0)
return makeHalfBankSwizzleLayout(mat_stride, mat_continuous, element_size);
else if (mat_continuous % (vector_size * 2) == 0)
return makeQuarterBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
else if (mat_continuous % vector_size == 0)
if (mat_stride % 8 == 0) {
if (mat_continuous % (vector_size * 8) == 0)
return makeFullBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
else if (mat_continuous % (vector_size * 4) == 0)
return makeHalfBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
else if (mat_continuous % (vector_size * 2) == 0)
return makeQuarterBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
}

if (mat_continuous % vector_size == 0)
return makeLinearLayout(
Array<PrimExpr>{Integer(mat_stride), Integer(mat_continuous)});
else
Expand All @@ -784,14 +793,20 @@ Layout makeGemmABLayoutSm100(int mat_stride, int mat_continuous, int continuity,
ICHECK(0) << "float64 on sm100 is not supported now";
}
int vector_size = 128 / element_size;
if (mat_continuous % (vector_size * 8) == 0)
return makeFullBankSwizzleLayout(mat_stride, mat_continuous, element_size);
else if (mat_continuous % (vector_size * 4) == 0)
return makeHalfBankSwizzleLayout(mat_stride, mat_continuous, element_size);
else if (mat_continuous % (vector_size * 2) == 0)
return makeQuarterBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
else if (mat_continuous % vector_size == 0)

if (mat_stride % 8 == 0) {
if (mat_continuous % (vector_size * 8) == 0)
return makeFullBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
else if (mat_continuous % (vector_size * 4) == 0)
return makeHalfBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
else if (mat_continuous % (vector_size * 2) == 0)
return makeQuarterBankSwizzleLayout(mat_stride, mat_continuous,
element_size);
}

if (mat_continuous % vector_size == 0)
return makeLinearLayout(
Array<PrimExpr>{Integer(mat_stride), Integer(mat_continuous)});
else
Expand Down
Loading