-
Notifications
You must be signed in to change notification settings - Fork 451
[Release] Bump version into 0.1.7.post1 #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0.1.7 | ||
| 0.1.7.post1 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,6 @@ | |
| from tvm.target import Target | ||
| from tilelang.contrib import hipcc, nvcc | ||
| from tilelang.transform import PassConfigKey | ||
| from tilelang.utils.deprecated import deprecated_warning | ||
| from tilelang.engine.param import KernelParam, CompiledArtifact | ||
| from tilelang.utils.target import determine_target | ||
| from tilelang.engine.phase import ( | ||
|
|
@@ -76,12 +75,7 @@ def tilelang_callback_cuda_compile(code, target, pass_config=None): | |
|
|
||
| # Read pass-config keys (string-valued) like in jit.adapter.libgen.compile_lib | ||
| cfg = pass_config or {} | ||
| if cfg.get(PassConfigKey.TL_DISABLE_FAST_MATH, False): | ||
| deprecated_warning("TL_DISABLE_FAST_MATH", "TL_ENABLE_FAST_MATH", "0.1.7") | ||
| disable_fast_math = bool(cfg.get(PassConfigKey.TL_DISABLE_FAST_MATH, True)) | ||
| enable_fast_math = not disable_fast_math | ||
| else: | ||
| enable_fast_math = bool(cfg.get(PassConfigKey.TL_ENABLE_FAST_MATH, False)) | ||
| enable_fast_math = bool(cfg.get(PassConfigKey.TL_ENABLE_FAST_MATH, False)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Search for any remaining references to TL_DISABLE_FAST_MATH in the codebase
echo "=== Searching for TL_DISABLE_FAST_MATH references ==="
rg -n 'TL_DISABLE_FAST_MATH' --type=py
echo ""
echo "=== Searching in documentation ==="
rg -n 'TL_DISABLE_FAST_MATH' --type=md
echo ""
echo "=== Searching in all file types (case-insensitive) ==="
rg -in 'disable.*fast.*math' --max-count=20Repository: tile-ai/tilelang Length of output: 575 🏁 Script executed: #!/bin/bash
# Verify the context around line 78 in tilelang/engine/lower.py
echo "=== Context around line 78 in lower.py ==="
sed -n '70,110p' tilelang/engine/lower.py | cat -nRepository: tile-ai/tilelang Length of output: 1927 🏁 Script executed: #!/bin/bash
# Check if TL_ENABLE_FAST_MATH is properly defined/used elsewhere
echo "=== Searching for TL_ENABLE_FAST_MATH usage ==="
rg -n 'TL_ENABLE_FAST_MATH' --type=pyRepository: tile-ai/tilelang Length of output: 10638 Critical issue: Incomplete deprecation of TL_DISABLE_FAST_MATH. While the code change at line 78 is technically correct in using only
Breaking change: Code using the old
|
||
|
|
||
| ptxas_usage_level = cfg.get(PassConfigKey.TL_PTXAS_REGISTER_USAGE_LEVEL, None) | ||
| verbose_ptxas_output = bool(cfg.get(PassConfigKey.TL_ENABLE_PTXAS_VERBOSE_OUTPUT, False)) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: tile-ai/tilelang
Length of output: 1231
🏁 Script executed:
Repository: tile-ai/tilelang
Length of output: 50372
🏁 Script executed:
Repository: tile-ai/tilelang
Length of output: 2743
Post-release versioning is inappropriate for removing public API.
According to semantic versioning best practices, deprecated APIs should first be marked in a minor release with warnings, and removal should only occur in a subsequent major release after users have time to migrate. The version bump to
0.1.7.post1violates this practice.Git history shows that
TL_DISABLE_FAST_MATHwas deprecated in commit e7e3835 (marked "will be deprecated in the 0.1.7 release"), but it has been completely removed from thePassConfigKeyenum in this post-release. This is a breaking change because users still actively usingTL_DISABLE_FAST_MATH(as seen inexamples/deepseek_v32/inference/kernel.py) will encounter errors.Post-release versions (
.post1) are reserved for packaging or distribution fixes without functional changes. Removing a public configuration key warrants at least a minor version bump (e.g.,0.2.0). If the deprecation was properly introduced in 0.1.7 with runtime warnings, a subsequent minor or major release should have been used for the actual removal.