Skip to content

[Bugfix][CI] Fix concurrency bug in regression test workflow#1500

Merged
LeiWang1999 merged 1 commit intotile-ai:mainfrom
xwhzz:main
Dec 22, 2025
Merged

[Bugfix][CI] Fix concurrency bug in regression test workflow#1500
LeiWang1999 merged 1 commit intotile-ai:mainfrom
xwhzz:main

Conversation

@xwhzz
Copy link
Contributor

@xwhzz xwhzz commented Dec 22, 2025

Updated concurrency group to use issue/PR number.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to improve job management efficiency.

✏️ Tip: You can customize this high-level summary in your review settings.

Updated concurrency group to use issue/PR number.
@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Walkthrough

A GitHub Actions workflow concurrency group was updated from using the workflow reference to using the PR issue number, changing how concurrent jobs are canceled across pull requests.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
\.github/workflows/pr-regression-test-bot.yml``
Updated concurrency group to use PR issue number instead of workflow reference for job cancellation coordination; cancel-in-progress behavior unchanged

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • LeiWang1999

Poem

🐇 A workflow so wise, now knows PR by its guise,
No more workflow refs in the skies—issue numbers rise!
Concurrency flows, cancellations precise,
Your regression tests run without any splice! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a concurrency bug in the CI regression test workflow by updating the concurrency group configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5acaab7 and c028961.

📒 Files selected for processing (1)
  • .github/workflows/pr-regression-test-bot.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Test for Python 3.12 with Nightly-ROCm-7.1 (on self-hosted-amd)
  • GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
  • GitHub Check: Test for Python 3.12 with CUDA-12.8 (on self-hosted-nvidia)
🔇 Additional comments (1)
.github/workflows/pr-regression-test-bot.yml (1)

13-16: LGTM! This correctly fixes the concurrency bug.

The change properly isolates concurrency groups per PR, preventing runs from different PRs from canceling each other. The cancel-in-progress: true setting ensures that if multiple regression tests are triggered on the same PR (e.g., via repeated @regression-perf comments), only the latest run proceeds. This is the correct behavior for per-PR performance testing.

The use of github.event.issue.number is appropriate here since it's available in the issue_comment event context and is already used successfully elsewhere in the workflow (line 41).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants