Skip to content

Conversation

@LeiWang1999
Copy link
Member

@LeiWang1999 LeiWang1999 commented Dec 22, 2025

Related to issue #1069 Though we have recur_depth_ to alleviate the time cost, recur_depth_ is incremented upon entering Eval(IntervalSet) and decremented upon exiting:

IntervalSet Eval(IntervalSet val) {
    if (recur_depth_ >= dom_map_.size()) return val;

    ++recur_depth_;
    IntervalSet min_set = this->Eval(val->min_value);  // Branch 1
    IntervalSet max_set = this->Eval(val->max_value);  // Branch 2
    --recur_depth_;  // Decrement when exiting!

    return ...;
}

Assuming there are N variables, and each variable’s range depends on k other variables:

  • Depth limit: N (controlled by recur_depth_)
  • Branching per level: up to k
  • Worst-case complexity: O(k^N) — which is exponential.

The new commit introduced a visiting_vars_ based solution to reduce the complexity into O(N^2).

Summary by CodeRabbit

  • Chores
    • Updated an external TVM component to a newer submodule version; no user-facing functional changes detected.

✏️ Tip: You can customize this high-level summary in your review settings.

* Deleted the dynamic shape example script `example_dynamic.py` and its corresponding test file `test_example_dynamic.py` to streamline the codebase.
* Removed unused dynamic tail split and dynamic alignment configurations from `builtin.h` and `pass_config.py`.
* Cleaned up the dynamic shape testing files to eliminate redundancy and improve maintainability.
@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Walkthrough

A submodule reference for 3rdparty/tvm was updated from commit 79ed747db67e60d3a1889d8afd33473bc2424ade to d9d3e9dff8a0ac05ed435b1c44461b765e5beaec. No other files or functional code changes were made.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/tvm
Submodule reference moved from 79ed747db67e60d3a1889d8afd33473bc2424ade to d9d3e9dff8a0ac05ed435b1c44461b765e5beaec. No code changes in the main repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify the target commit hash d9d3e9dff8a0ac05ed435b1c44461b765e5beaec is intended.
  • Confirm there are no local modifications inside the 3rdparty/tvm submodule.

Poem

🐰 A tiny hop to a newer tree,
A hash replaced, as light as can be,
No lines changed, just paths align—
I nibble code crumbs and dance in time. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title describes an optimization for IntervalSetEvaluator's critical path, which matches the actual change of updating a submodule (tvm) that presumably contains this optimization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27de539 and 1c71ef6.

📒 Files selected for processing (1)
  • 3rdparty/tvm
🚧 Files skipped from review as they are similar to previous changes (1)
  • 3rdparty/tvm
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
  • GitHub Check: Test for Python 3.12 with Nightly-ROCm-7.1 (on self-hosted-amd)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeiWang1999 LeiWang1999 merged commit a431797 into tile-ai:main Dec 22, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant