[Dev] Fix when build local version with isolated build#1487
[Dev] Fix when build local version with isolated build#1487LeiWang1999 merged 5 commits intotile-ai:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
📝 WalkthroughWalkthroughCMakeLists.txt now installs the Z3 library into the build Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CMakeLists.txt (1)
326-332: Optional: Simplify redundant conditional check.The
if(USE_Z3 AND USE_PYPI_Z3)check on line 326 is redundant if the previous fix is applied, since this entire block would already be inside the same conditional. The BUILD_RPATH logic itself is correct.🔎 Suggested simplification (if previous fix applied)
if(USE_Z3 AND USE_PYPI_Z3) # Copy libz3 library to build folder to workaround isolated build env issue get_target_property(Z3_LIBRARY_PATH z3::libz3 IMPORTED_LOCATION) file(COPY "${Z3_LIBRARY_PATH}" DESTINATION "${CMAKE_BINARY_DIR}/tvm") - if(USE_Z3 AND USE_PYPI_Z3) - if(APPLE) - set_target_properties(tvm PROPERTIES BUILD_RPATH "@loader_path") - else() - set_target_properties(tvm PROPERTIES BUILD_RPATH "\$ORIGIN") - endif() + if(APPLE) + set_target_properties(tvm PROPERTIES BUILD_RPATH "@loader_path") + else() + set_target_properties(tvm PROPERTIES BUILD_RPATH "\$ORIGIN") endif() endif()
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CMakeLists.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Test for Python 3.12 with Nightly-ROCm-7.1 (on self-hosted-amd)
- GitHub Check: Test for Python 3.12 with Metal (on macos-latest)
- GitHub Check: Test for Python 3.12 with CUDA-12.8 (on self-hosted-nvidia)
- GitHub Check: Build wheels for Python 3.9 on macos-latest with Metal
- GitHub Check: Build wheels for Python 3.9 on ubuntu-24.04-arm with CUDA-12.8
- GitHub Check: Build wheels for Python 3.9 on ubuntu-latest with CUDA-12.8
- GitHub Check: Build SDist
|
Thanks @oraluben, concise and effective! I'll check the cutedsl CI |
d7ad8b0 to
b75cfb9
Compare
|
Could not reproduce the test failure on my local H20, both with wheel installed / with local libraries from |
Fix the problem that #1485 trying to notify in a more elegant way.
cc @kurisu6912
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.