Skip to content

[Fix] typo in cuda attr #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeiWang1999 merged 3 commits into from
Dec 6, 2025
Merged

[Fix] typo in cuda attr #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a00f265
[Bugfix] make cuda driver api compat with cuda12/13, along with tests
PannenetsF Dec 6, 2025
0faebaa
fix typo in cudaDevAttr
PannenetsF Dec 6, 2025
95f4f0f
Merge branch 'main' into yq/cuda13-driver-api
PannenetsF Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion testing/python/carver/test_tilelang_carver_cuda_driver_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class _cudaDeviceAttrNames:

cudaDevAttrMaxThreadsPerBlock: int = 1
cudaDevAttrMaxSharedMemoryPerBlock: int = 8
cudaDevAttrMaxRegistersPerBlock: int = 12
cudaDevAttrMultiProcessorCount: int = 16
cudaDevAttrMaxSharedMemoryPerMultiprocessor: int = 81
cudaDevAttrMaxPersistingL2CacheSize: int = 108
Expand Down Expand Up @@ -60,7 +61,8 @@ def test_device_get_num_sms():

def test_device_get_registers_per_block():
tl_regs_per_block = get_registers_per_block()
driver_regs_per_block = get_device_attribute(_cudaDeviceAttrNames.cudaDevAttrMaxThreadsPerBlock)
driver_regs_per_block = get_device_attribute(
_cudaDeviceAttrNames.cudaDevAttrMaxRegistersPerBlock)
assert tl_regs_per_block == driver_regs_per_block, "Registers per block values do not match"


Expand Down
5 changes: 4 additions & 1 deletion tilelang/carver/arch/driver/cuda_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class cudaDeviceAttrNames:
"""

cudaDevAttrMaxThreadsPerBlock: int = 1
cudaDevAttrMaxRegistersPerBlock: int = 12
cudaDevAttrMaxSharedMemoryPerMultiprocessor: int = 81
cudaDevAttrMaxPersistingL2CacheSize: int = 108

Expand All @@ -38,6 +39,8 @@ def get_device_name(device_id: int = 0) -> str | None:
def get_shared_memory_per_block(device_id: int = 0, format: str = "bytes") -> int | None:
assert format in ["bytes", "kb", "mb"], "Invalid format. Must be one of: bytes, kb, mb"
prop = get_cuda_device_properties(device_id)
if prop is None:
raise RuntimeError("Failed to get device properties.")
shared_mem = int(prop.shared_memory_per_block)
if format == "bytes":
return shared_mem
Expand Down Expand Up @@ -121,7 +124,7 @@ def get_registers_per_block(device_id: int = 0) -> int:
Get the maximum number of 32-bit registers available per block.
"""
prop = get_device_attribute(
cudaDeviceAttrNames.cudaDevAttrMaxThreadsPerBlock,
cudaDeviceAttrNames.cudaDevAttrMaxRegistersPerBlock,
device_id,
)
return prop
Loading