-
Notifications
You must be signed in to change notification settings - Fork 446
[Refactor] Phaseout legacy loop vectorize dynamic pass #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Deleted the LoopVectorizeDynamic implementation from the transform module. * Removed associated references in the phase and initialization files to streamline the codebase. * This change simplifies the transformation pipeline by eliminating unused functionality.
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
WalkthroughThe changes remove the dynamic loop vectorization feature completely. This includes deletion of the implementation file, removal of the pass from the lowering pipeline, and removal of its public API function, leaving no dynamic vectorization capabilities in the codebase. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* Deleted the LoopVectorizeDynamic implementation from the transform module. * Removed associated references in the phase and initialization files to streamline the codebase. * This change simplifies the transformation pipeline by eliminating unused functionality. Co-authored-by: Zhiwen Mo <[email protected]>
This pull request removes the
LoopVectorizeDynamictransformation pass from both the implementation and its usage in the codebase. This streamlines the lowering phase by no longer attempting to vectorize loops with dynamic shapes, likely due to changes in upstream dependencies or project direction.Removals related to loop vectorization:
tilelang.transform.LoopVectorizeDynamic()from theLowerAndLegalizefunction intilelang/engine/phase.py, so loops with dynamic shapes are no longer vectorized during this phase.LoopVectorizeDynamicfunction fromtilelang/transform/__init__.py, fully removing its definition and documentation.Other changes:
.git_commit.txtfile with a new commit hash, likely reflecting the latest upstream or submodule state.Summary by CodeRabbit
Chores
Revert