-
Notifications
You must be signed in to change notification settings - Fork 332
[Release] Bump version to v0.1.6.post2 #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds multi-architecture build/distribute support and Buildx/binfmt orchestration, tightens packaging include lists, bumps release to 0.1.6.post2 with README note, updates .gitignore, and adjusts distribution cleanup and manylinux Dockerfile for arch/ENV handling. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Host as Maint script (host)
participant Buildx as Docker buildx
participant Daemon as Docker daemon
participant Img as Per-arch image
participant Container as Container run
participant FS as Host FS
Host->>Buildx: check buildx availability
alt buildx available
Host->>Daemon: enable binfmt & ensure builder "multi"
Host->>Daemon: build image for each ARCH (TARGETARCH)
Daemon-->>Img: tilelang-builder-ARCH (loaded)
Host->>Img: docker run --platform ARCH -> execute distribution script
Img->>Container: start and run local_distribution.sh
Container->>FS: write `dist` → rename to `dist-ARCH` (arch-specific)
else buildx not available
Host->>Daemon: build single image for host TARGETARCH
Daemon-->>Img: tilelang-builder-TARGETARCH
Host->>Img: docker run -> execute distribution script
Container->>FS: write `dist` → rename to `dist-TARGETARCH`
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
…ulti-architecture support * Add allowlist for TVM, CUTLASS, and Composable Kernel items in pyproject.toml * Enhance docker_local_distribute.sh to support cross-architecture builds using docker buildx * Modify pypi.manylinux.Dockerfile to accept TARGETARCH argument for better architecture handling
…itecture support * Update .gitignore to include dist directories * Refactor docker_local_distribute.sh for better cross-architecture handling and error management * Enhance docker_pypi_distribute.sh to support multi-architecture builds with docker buildx * Modify pypi_distribution.sh to clean up additional directories * Update pypi.manylinux.Dockerfile for improved environment configuration and architecture handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
92-102: Clarify the misleading comment on Line 92 about "same allowlist."The wheel package mappings are valid—web search confirms all mapped paths exist in their upstream repositories: TVM has
src/,python/, andversion.py; CUTLASS hasinclude/andtools/; Composable Kernel hasinclude/andlibrary/. However, the comment on Line 92 is inaccurate. The wheel scope is intentionally narrower than the sdist, not "the same"—sdist includes all3rdparty/**(except clang/llvm exclusions), while wheel maps only these three specific subdirectories. This is the correct approach to minimize wheel size, but the comment should reflect that distinction.Suggested fix: Update Line 92 comment to clarify intent, e.g., "Restrict 3rdparty contents in wheel to essential runtime dependencies (TVM, CUTLASS, Composable Kernel)" or similar.
Wheel builds should succeed once submodules are initialized during the actual build process.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Test for Python 3.12 with CUDA-12.8 (on self-hosted-nvidia)
- GitHub Check: Test for Python 3.12 with ROCm-6.3 (on self-hosted-amd)
- GitHub Check: Build wheels for Python 3.8 on ubuntu-latest with CUDA-12.1
- GitHub Check: Build wheels for Python 3.8 on ubuntu-24.04-arm with CUDA-12.8
- GitHub Check: Build wheels for Python 3.8 on macos-latest with Metal
- GitHub Check: Build SDist
…pts for clarity * Add new classifier for Artificial Intelligence in pyproject.toml * Rename output directories in docker_local_distribute.sh and docker_pypi_distribute.sh for better context
* [Release] Update README and VERSION for v0.1.6.post2 compatibility with Python 3.8 * [Enhancement] Update packaging configuration and Docker scripts for multi-architecture support * Add allowlist for TVM, CUTLASS, and Composable Kernel items in pyproject.toml * Enhance docker_local_distribute.sh to support cross-architecture builds using docker buildx * Modify pypi.manylinux.Dockerfile to accept TARGETARCH argument for better architecture handling * [Enhancement] Improve Docker scripts and build process for multi-architecture support * Update .gitignore to include dist directories * Refactor docker_local_distribute.sh for better cross-architecture handling and error management * Enhance docker_pypi_distribute.sh to support multi-architecture builds with docker buildx * Modify pypi_distribution.sh to clean up additional directories * Update pypi.manylinux.Dockerfile for improved environment configuration and architecture handling * fix * Remove outdated classifier for Artificial Intelligence from pyproject.toml * Update pyproject.toml classifiers and modify Docker distribution scripts for clarity * Add new classifier for Artificial Intelligence in pyproject.toml * Rename output directories in docker_local_distribute.sh and docker_pypi_distribute.sh for better context
the last version compatible with Python 3.8.
Summary by CodeRabbit
Chores
Documentation
Packaging