Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete context during setup only if route is defined #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delete context during setup only if route is defined #322

wants to merge 1 commit into from
+2 −1

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Mar 9, 2021 •
edited
Loading

Necessary for emberjs/ember.js#19266

@rwjblue Do you think there could be a demonstrating failing test in this repo ?

@sly7-7 sly7-7 mentioned this pull request Mar 9, 2021
Draft
rwjblue
rwjblue reviewed Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the right change here. I would definitely like to add a test here to try to prevent an accidental regression, I think it would fit with these tests:

https://github.com/tildeio/router.js/blob/master/tests/async_get_handler_test.ts

@rwjblue rwjblue added the bug label Mar 9, 2021
@wagenet
Copy link
Collaborator

wagenet commented Feb 9, 2022

@sly7-7 status?

@sly7-7 sly7-7 mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sly7-7 @wagenet @rwjblue