Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isIntermediate flag to Transition #321

Merged

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Mar 7, 2021

This is a prerequisite to fix emberjs/ember.js#19449

cc/ @rwjblue

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the internal transition constructor to set this.isIntermediateTransition = false?

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind! I misread the diff on mobile. 😝

@rwjblue rwjblue merged commit fe716d5 into tildeio:master Mar 7, 2021
@rwjblue rwjblue changed the title introduce isIntermediate flag in transition introduce Add isIntermediate flag to Transition Mar 7, 2021
@rwjblue rwjblue changed the title introduce Add isIntermediate flag to Transition Add isIntermediate flag to Transition Mar 7, 2021
@sly7-7 sly7-7 deleted the introduce-intermediate-flag-in-transition branch March 7, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Router Service doesn't update currentRoute on loading states
2 participants