Simplify TransitionState resolution system. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
commented
Sep 10, 2020
rwjblue
force-pushed
the
refactor-transition-state-resolution
branch
from
e83d0f9
to
2644d95
Compare
|
Note: I confirmed that Ember's test suite passes with these changes (when linked locally). |
This was referenced Nov 6, 2020
stefanpenner
force-pushed
the
refactor-transition-state-resolution
branch
from
2644d95
to
bc0ef9f
Compare
|
rebased on top of master + tested |
stefanpenner
reviewed
Nov 6, 2020
stefanpenner
reviewed
Nov 6, 2020
lib/router/transition-state.ts
Outdated
| // We distinguish between errors that occurred | ||
| // during resolution (e.g. before"Model/model/afterModel), | ||
| // and aborts due to a rejecting promise from shouldContinue(). | ||
| wasAborted = true; | ||
| return Promise.reject(reason); | ||
| }, currentState.promiseLabel('Handle abort')); | ||
| throw new Error('Transition aborted'); |
There was a problem hiding this comment.
given e83c782#r518934850 is this else unreachable?
There was a problem hiding this comment.
guess this is ultimately removed, so it doesn't matter.
stefanpenner
requested changes
Nov 6, 2020
|
@stefanpenner I was following the work here and noticed some changes that might be related to this pull request: Do you think the issue is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuationsystem (usetransition.isAborteddirectly)