Added support for mustaches beginning with @#98
Added support for mustaches beginning with @#98amiller-gh wants to merge 2 commits intotildeio:masterfrom
Conversation
- Mustaches begining with @ dont have the string attribute defined in the handlebars ast. - If a mustache does not have the string attribute present in hydration_opcode.js, use idName instead. Added missing semicolin for element cache in templates.
|
@EpicMiller would definitely want to see some tests here. Not quite sure what role /cc @mmun |
|
@EpicMiller What's your motivation behind this? We're planning on implementing something more general than In the interim we could merge this so that we can at least treat |
|
Commented on the RFC with my thoughts on the larger block params problem, and hopefully with what counts as the motivation behind this. emberjs/rfcs#3 Tests can be added :) |
Conflicts: packages/htmlbars-compiler/lib/compiler/hydration_opcode.js
|
This "just works" with the new Handlebars AST. |
Because the handlebars parser treats mustaches beginning with @ differently (see @DaTa variables: http://handlebarsjs.com/reference.html), they do not have the
stringattribute assigned to them from the ast generated from handlebars. In order to allow other frameworks to support having their own @DaTa variables, modify hydration_opcode.js to accept eitherstringoridNameas the mustache identifier.tl;dr: