Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Embroider v1 deps; Drop node v10 #74

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

josemarluedke
Copy link
Contributor

Node 10 is not compatible with embroider v1.

@josemarluedke
Copy link
Contributor Author

Pushed a commit adding ember-source as peer dep because newer embroider macros's dependencySatisfies needs it to work reliable. See embroider-build/embroider#1070

Tests should pass now.

@josemarluedke
Copy link
Contributor Author

Failing tests are due to Ember v4 requiring ember-auto-import v2. Which can be solved in other PR.

@cibernox
Copy link
Collaborator

cibernox commented Feb 1, 2022

Since that is a different issue I'm going to merge this as is

@cibernox cibernox merged commit b48abc0 into tildeio:main Feb 1, 2022
@cibernox
Copy link
Collaborator

cibernox commented Feb 1, 2022

thanks!

@josemarluedke josemarluedke deleted the embroider-v1 branch February 1, 2022 19:48
@cibernox
Copy link
Collaborator

cibernox commented Feb 1, 2022

@josemarluedke to clarify, are you upgrading ember-auto-import next?

@josemarluedke
Copy link
Contributor Author

@cibernox PR coming.

@jamescdavis
Copy link

Can we get a release with this? 🙂

@josemarluedke
Copy link
Contributor Author

I think we can merge #73 and then release it. Looking forward to have a release out as well.

@simonihmig simonihmig added breaking enhancement New feature or request labels Feb 5, 2022
@lifeart
Copy link

lifeart commented Feb 8, 2022

adding more search keywords here, updating to 0.6.0 from 0.5.5 fixes

Build Error (broccoli-persistent-filter:Babel > [Babel: @embroider/macros]) in @embroider/macros/runtime.js

C:\Users\lifeart\Documents\repos\smassetman_spa\smassetman\@embroider\macros\runtime.js: @babel/template placeholder "OPTIONS": Expected string substitution

error for me, as I understand, it's related to @embroider/util version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants