Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addon to support ember v5 #105

Merged
merged 14 commits into from
Jul 25, 2023
Merged

Update addon to support ember v5 #105

merged 14 commits into from
Jul 25, 2023

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Jul 24, 2023 •
edited
Loading

fix #104

  • update test-app to ember v4.12
  • allow ember v5 as peerDependency

@mkszepp mkszepp changed the title Update to support ember v5 Update addon to support ember v5 Jul 24, 2023
@NullVoxPopuli
Copy link
Collaborator

thanks for submitting!!!

@NullVoxPopuli
Copy link
Collaborator

I'll take care of the rebase, no worries!

@NullVoxPopuli NullVoxPopuli added internal enhancement New feature or request labels Jul 25, 2023
@NullVoxPopuli NullVoxPopuli merged commit c703e3c into tildeio:main Jul 25, 2023
15 checks passed
@mkszepp mkszepp deleted the ember-v5-support branch July 26, 2023 05:13
@mkszepp
Copy link
Contributor Author

mkszepp commented Jul 26, 2023

@NullVoxPopuli thank you 🚀!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ember-source for addon is incompatible with ember 5.0.0
2 participants
@mkszepp @NullVoxPopuli