rocksdb: add Env related API #103
Conversation
Signed-off-by: Cholerae Hu <[email protected]>
| @@ -949,6 +974,10 @@ impl Options { | |||
| crocksdb_ffi::crocksdb_options_set_allow_concurrent_memtable_write(self.inner, v); | |||
| } | |||
| } | |||
|
|
|||
| pub fn set_env(&mut self, env: &Env) { | |||
There was a problem hiding this comment.
I think you should keep the Env in the Options. Otherwise, the Env may be destroyed quickly when dropping Env.
There was a problem hiding this comment.
We need to share Env among two or more db instances, but Options cannot be shared. We should keep Env's lifetime as the same to databases.
There was a problem hiding this comment.
It is bad to let the users manage the lifetime of Env. We should use DB outside only.
librocksdb_sys/src/lib.rs
Outdated
| @@ -216,6 +217,13 @@ pub enum DBTableProperty { | |||
| CompressionName = 17, | |||
| } | |||
|
|
|||
| #[repr(C)] | |||
| pub enum Priority { | |||
src/rocksdb_options.rs
Outdated
|
|
||
| pub fn set_background_threads(&mut self, n: Priority) { | ||
| unsafe { | ||
| crocksdb_ffi::crocksdb_env_set_background_threads(self.inner, n); |
There was a problem hiding this comment.
You should also use crocksdb_env_set_high_priority_background_threads.
Signed-off-by: Cholerae Hu <[email protected]>
|
After discuss with jinpeng, we found out that thread pool is a singleton, we don't need to expose Env API. So close this PR. |
|
so, how do we share the same Env with multi rocksdbs? |
|
We do not need to do this. All rocksdb will share one thread pool implicitly. |
PTAL @zhangjinpeng1987 @siddontang @andelf
Signed-off-by: Cholerae Hu [email protected]