Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust cmakefile #4

Merged
merged 4 commits into from
Nov 22, 2017
Merged

Adjust cmakefile #4

merged 4 commits into from
Nov 22, 2017

Commits on Nov 21, 2017

  1. cmake: support more compression type 

    Summary:
This pr enables linking all the supported compression libraries via cmake.
Closes facebook#2552

Differential Revision: D5620607

Pulled By: yiwu-arbug

fbshipit-source-id: b6949181f305bfdf04a98f898c92fd0caba0c45a
    @BusyJay
    BusyJay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    393b624 View commit details
    Browse the repository at this point in the history

  2. Use cmake TIMESTAMP function 

    Summary:
because it is not only platform independent
but also allows to override the build date
This helps to make ceph builds reproducible (that includes a fork of rockdb in a submodule)

Also adds UTC flag, to be independent of timezone.

Requires cmake-2.8.11+ from 2013
Closes facebook#2848

Differential Revision: D5820189

Pulled By: yiwu-arbug

fbshipit-source-id: e3e8c1550e10e238c173f6c5d9ba15f71ad3ce28
    @bmwiedemann @BusyJay
    bmwiedemann authored and BusyJay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    8fe21ce View commit details
    Browse the repository at this point in the history

  3. Update cmake_minimum_required to 2.8.12. 

    Summary:
Hello,

current master branch declares cmake_minimum_required (VERSION 2.8.11)
but cmake gives the following error:

[  6%] CMake Error at CMakeLists.txt:658 (install):
  install TARGETS given unknown argument "INCLUDES".

CMake Error at src/CMakeLists.txt:658 (install): install TARGETS given unknown argument "INCLUDES".

because this argument not supported on CMake versions prior 2.8.12
Closes facebook#2904

Differential Revision: D5863430

Pulled By: yiwu-arbug

fbshipit-source-id: 0f7230e080add472ad4b87836b3104ea0b971a38
    @yaozongyou @BusyJay
    yaozongyou authored and BusyJay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    8ecc536 View commit details
    Browse the repository at this point in the history

  4. cmake: pass "-msse4.2" to when building crc32c.cc if HAVE_SSE42 

    Summary:
it turns out that, with older GCC shipped from centos7, the SSE42
intrinsics are not available even with "target" specified. so we
need to pass "-msse42" for checking compiler's sse4.2 support and
for building crc32c.cc which uses sse4.2 intrinsics for crc32.

Signed-off-by: Kefu Chai <[email protected]>
Closes facebook#2950

Differential Revision: D6032298

Pulled By: siying

fbshipit-source-id: 124c946321043661b3fb0a70b6cdf4c9c5126ab4
    @tchaikov @BusyJay
    tchaikov authored and BusyJay committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    794e69e View commit details
    Browse the repository at this point in the history