Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: use log2 for y-axis of uptime #8240

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

jackysp
Copy link
Contributor

@jackysp jackysp commented Jun 3, 2024

What problem does this PR solve?

Issue Number: Close #8241

What is changed and how does it work?

Use log2 for y-axis of uptime.

Close #8241
grafana: use log2 for y-axis of uptime

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx June 3, 2024 08:13
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

@okJiang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.44%. Comparing base (d44d721) to head (d6cd859).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8240      +/-   ##
==========================================
- Coverage   77.46%   77.44%   -0.03%     
==========================================
  Files         471      471              
  Lines       61365    61365              
==========================================
- Hits        47539    47524      -15     
- Misses      10275    10285      +10     
- Partials     3551     3556       +5     
Flag Coverage Δ
unittests 77.44% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2024
@nolouch
Copy link
Contributor

nolouch commented Jun 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3ccf193

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the dco-signoff: no Indicates the PR's author has not signed dco. label Jun 4, 2024
@nolouch
Copy link
Contributor

nolouch commented Jun 4, 2024

/check-dco

@nolouch nolouch closed this Jun 4, 2024
@nolouch nolouch reopened this Jun 4, 2024
@nolouch
Copy link
Contributor

nolouch commented Jun 4, 2024

/check-dco

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@jackysp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Jun 5, 2024

/check-dco

@ti-chi-bot ti-chi-bot bot removed the dco-signoff: no Indicates the PR's author has not signed dco. label Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jun 5, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented Jun 5, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 82d3a4a into tikv:master Jun 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The y-axis of uptime can be displayed using log2
4 participants