-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unsafe recovery: Add newly created empty regions output for 6.5 #6877
base: release-6.5
Are you sure you want to change the base?
Conversation
…overy Signed-off-by: Yang Zhang <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @disksing @Connor1996 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #6877 +/- ##
===============================================
+ Coverage 75.54% 75.65% +0.11%
===============================================
Files 328 328
Lines 33168 33176 +8
===============================================
+ Hits 25056 25100 +44
+ Misses 5944 5924 -20
+ Partials 2168 2152 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
} | ||
details = append(details, "newly created empty regions: "+strings.Trim(regions, ", ")) | ||
} else { | ||
details = append(details, "no newly created empty regions") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will using strings.Builder
here gain better performance?
What problem does this PR solve?
Issue Number: Ref #6715
What is changed and how does it work?
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
Master branch PR: #6869
Release note