Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe recovery: Add newly created empty regions output for 6.5 #6877

Open
wants to merge 1 commit into
base: release-6.5
Choose a base branch
from

Conversation

v01dstar
Copy link
Contributor

@v01dstar v01dstar commented Aug 1, 2023

What problem does this PR solve?

Issue Number: Ref #6715

What is changed and how does it work?

This is a manual cherry-pick for release 6.5.

In DR auto sync scenario, it is possible that a empty range hole is left in the secondary data center 
when the primary data center is totally unavailable and the replication mode is "sync recover" (super 
rare). In this case, unsafe recovery + flashback is not able to recover the cluster. The fallback 
is BR + PiTR.  While, to help the people faster identify whether the fallback is needed, we need to add 
empty regions info in the output of unsafe recovery.

If there are empty regions created, use BR+PiTR. If there are no empty regions, use flashback.

Check List

Tests

  • No code

Code changes

N/A

Side effects

N/A

Related changes

Master branch PR: #6869

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 1, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and JmPotato August 1, 2023 18:39
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2023
@v01dstar
Copy link
Contributor Author

v01dstar commented Aug 1, 2023

/cc @disksing @Connor1996

@ti-chi-bot ti-chi-bot bot requested review from Connor1996 and disksing August 1, 2023 18:42
@v01dstar
Copy link
Contributor Author

v01dstar commented Aug 1, 2023

@mayjiang0203

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (2892b46) 75.54% compared to head (a2588c6) 75.65%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6877      +/-   ##
===============================================
+ Coverage        75.54%   75.65%   +0.11%     
===============================================
  Files              328      328              
  Lines            33168    33176       +8     
===============================================
+ Hits             25056    25100      +44     
+ Misses            5944     5924      -20     
+ Partials          2168     2152      -16     
Flag Coverage Δ
unittests 75.65% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/cluster/unsafe_recovery_controller.go 82.79% <100.00%> (+0.57%) ⬆️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}
details = append(details, "newly created empty regions: "+strings.Trim(regions, ", "))
} else {
details = append(details, "no newly created empty regions")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will using strings.Builder here gain better performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants