Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update store leader count hideZero is false #5263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glkappe
Copy link

@glkappe glkappe commented Jul 4, 2022

What problem does this PR solve?

Issue Number: Close #xxx

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

When upgrading the cluster, the node leader count cannot be accurately seen

origin_img_v2_93cf3395-5ea6-4f2f-8ee7-687276631c0g

Please add a release note.

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 4, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 4, 2022
@ti-chi-bot ti-chi-bot requested review from rleungx and Yisaer July 4, 2022 10:02
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 4, 2022
@nolouch
Copy link
Contributor

nolouch commented Jul 4, 2022

Hi @glkappe , thanks for your contribution.
you need to pass the DCO test, plz see the https://github.com/tikv/pd/pull/5263/checks?check_run_id=7178330709. may you can try:

git rebase HEAD~1 --signoff

@@ -4309,7 +4309,7 @@
"avg": false,
"current": true,
"hideEmpty": true,
"hideZero": true,
"hideZero": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only modifies the region count, maybe the leader count also need to be changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, cc @glkappe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,我们默认的模板可以修改下吗?

@bufferflies bufferflies changed the title update 「store leader count」hideZero is false update store leader count hideZero is false Aug 1, 2022
@ti-chi-bot
Copy link
Member

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants