Push metrics #325
Merged
Push metrics #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
PTAL @huachaohuang |
| addr, | ||
| prometheus.DefaultGatherer, | ||
| ); err != nil { | ||
| fmt.Println("Could not push metrics to Prometheus Pushgateway:", err) |
There was a problem hiding this comment.
Shouldn't we use log here?
| // MetricConfig is the metric configuration. | ||
| type MetricConfig struct { | ||
| PushAddress string `toml:"address" json:"address"` | ||
| PushInterval time.Duration `toml:"interval" json:"interval"` |
There was a problem hiding this comment.
time.Duration can not be parsed by toml, you can use the duration instead.
|
LGTM |
pingyu
added a commit
to pingyu/pd
that referenced
this pull request
Jan 24, 2025
* keyspace: Async create pre-alloc keyspaces Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * fix fmt Signed-off-by: Ping Yu <[email protected]> * create parallel; fix ut Signed-off-by: Ping Yu <[email protected]> * fix lint Signed-off-by: Ping Yu <[email protected]> * fix lint Signed-off-by: Ping Yu <[email protected]> * fix lint Signed-off-by: Ping Yu <[email protected]> * fix ut; set fast-fail to false Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * fix ut Signed-off-by: Ping Yu <[email protected]> * fix data race Signed-off-by: Ping Yu <[email protected]> * increase concurrency Signed-off-by: Ping Yu <[email protected]> * wait keyspaces created Signed-off-by: Ping Yu <[email protected]> * add comments Signed-off-by: Ping Yu <[email protected]> * polish Signed-off-by: Ping Yu <[email protected]> * more wait keyspaces Signed-off-by: Ping Yu <[email protected]> * improve wait keyspaces Signed-off-by: Ping Yu <[email protected]> * fix TestKeyspace Signed-off-by: Ping Yu <[email protected]> * fix not determined keyspace id Signed-off-by: Ping Yu <[email protected]> --------- Signed-off-by: Ping Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review b19e15c
Close #321
Ref tikv/tikv#1065