Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #383] fix integration test case flow_control & stop_downstream #392

Merged
merged 17 commits into from
Mar 4, 2024

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Feb 11, 2024

What problem does this PR solve?

Issue Number: close #383, close #393

Problem Description: integration test case flow_control/stop_downstream is flaky

What is changed and how does it work?

  • Reuse allocated buffer for mq encoder.
  • Fix incorrect calculation of encoder size.
  • Reduce sarama.MaxRequestSize to reasonable value (1GiB -> 100MiB).
  • Decrease record size of go-ycsb workload from 1KB to 250B.
  • Retry PD connection with unlimited count.
  • Fix flaky unit tests of mq_test & kafka_test.
  • Add Grafana panel for Kafka sink.
image

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Integration test

Side effects

  • No side effects

Related changes

  • No related changes

To reviewers

Please follow these principles to check this pull requests:

  • Concentration. One pull request should only do one thing. No matter how small it is, the change does exactly one thing and gets it right. Don't mix other changes into it.
  • Tests. A pull request should be test covered, whether the tests are unit tests, integration tests, or end-to-end tests. Tests should be sufficient, correct and don't slow down the CI pipeline largely.
  • Functionality. The pull request should implement what the author intends to do and fit well in the existing code base, resolve a real problem for TiDB/TiKV users. To get the author's intention and the pull request design, you could follow the discussions in the corresponding GitHub issue or internal.tidb.io topic.
  • Style. Code in the pull request should follow common programming style. (For Go, we have style checkers in CI). However, sometimes the existing code is inconsistent with the style guide, you should maintain consistency with the existing code or file a new issue to fix the existing code style first.
  • Documentation. If a pull request changes how users build, test, interact with, or release code, you must check whether it also updates the related documentation such as READMEs and any generated reference docs. Similarly, if a pull request deletes or deprecates code, you must check whether or not the corresponding documentation should also be deleted.
  • Performance. If you find the pull request may affect performance, you could ask the author to provide a benchmark result.

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

Signed-off-by: Ping Yu <[email protected]>
@ti-chi-bot ti-chi-bot bot added the size/S label Feb 11, 2024
@pingyu
Copy link
Collaborator Author

pingyu commented Feb 11, 2024

/test ?

Copy link

ti-chi-bot bot commented Feb 11, 2024

@pingyu: The following commands are available to trigger required jobs:

  • /test pull-integration-kafka-test
  • /test pull-integration-test
  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 11, 2024

/test pull-integration-kafka-test

2 similar comments
@pingyu
Copy link
Collaborator Author

pingyu commented Feb 11, 2024

/test pull-integration-kafka-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 11, 2024

/test pull-integration-kafka-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 11, 2024

/test pull-integration-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 12, 2024

/test pull-integration-kafka-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 12, 2024

/test pull-integration-test

1 similar comment
@pingyu
Copy link
Collaborator Author

pingyu commented Feb 13, 2024

/test pull-integration-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 13, 2024

/test pull-integration-kafka-test

@pingyu pingyu changed the title [close #383] WIP: fix integration test case flow_control [close #383] fix integration test case flow_control & stop_downstream Feb 13, 2024
@pingyu
Copy link
Collaborator Author

pingyu commented Feb 13, 2024

/test pull-integration-kafka-test

Signed-off-by: Ping Yu <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Feb 13, 2024
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Feb 13, 2024
@pingyu
Copy link
Collaborator Author

pingyu commented Feb 14, 2024

/test pull-integration-kafka-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 14, 2024

/test pull-integration-test

@pingyu
Copy link
Collaborator Author

pingyu commented Feb 14, 2024

/test pull-integration-kafka-test

Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu
Copy link
Collaborator Author

pingyu commented Mar 2, 2024

/test pull-unit-test

1 similar comment
@pingyu
Copy link
Collaborator Author

pingyu commented Mar 2, 2024

/test pull-unit-test

Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Mar 2, 2024
@pingyu
Copy link
Collaborator Author

pingyu commented Mar 2, 2024

/test pull-unit-test

1 similar comment
@pingyu
Copy link
Collaborator Author

pingyu commented Mar 3, 2024

/test pull-unit-test

Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu pingyu requested a review from zeminzhou March 4, 2024 01:25
@pingyu pingyu merged commit 40357a1 into tikv:main Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants