Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #338] *: upgrade to Go 1.19 #337

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Feb 17, 2023

What problem does this PR solve?

Issue Number: close #338

Problem Description: Upgrade to Go 1.19

What is changed and how does it work?

  • Upgrade to Go 1.19
  • Upgrade version of toolchain
  • Apply changes of make dev

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Side effects

  • No side effects

Related changes

  • No related changes

To reviewers

Please follow these principles to check this pull requests:

  • Concentration. One pull request should only do one thing. No matter how small it is, the change does exactly one thing and gets it right. Don't mix other changes into it.
  • Tests. A pull request should be test covered, whether the tests are unit tests, integration tests, or end-to-end tests. Tests should be sufficient, correct and don't slow down the CI pipeline largely.
  • Functionality. The pull request should implement what the author intends to do and fit well in the existing code base, resolve a real problem for TiDB/TiKV users. To get the author's intention and the pull request design, you could follow the discussions in the corresponding GitHub issue or internal.tidb.io topic.
  • Style. Code in the pull request should follow common programming style. (For Go, we have style checkers in CI). However, sometimes the existing code is inconsistent with the style guide, you should maintain consistency with the existing code or file a new issue to fix the existing code style first.
  • Documentation. If a pull request changes how users build, test, interact with, or release code, you must check whether it also updates the related documentation such as READMEs and any generated reference docs. Similarly, if a pull request deletes or deprecates code, you must check whether or not the corresponding documentation should also be deleted.
  • Performance. If you find the pull request may affect performance, you could ask the author to provide a benchmark result.

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

Signed-off-by: Ping Yu <[email protected]>
@pingyu pingyu marked this pull request as draft February 17, 2023 15:41
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #337 (a3abefb) into main (0966ba8) will decrease coverage by 0.1479%.
The diff coverage is 0.0000%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #337        +/-   ##
================================================
- Coverage   61.0409%   60.8930%   -0.1479%     
================================================
  Files           240        240                
  Lines         20270      20334        +64     
================================================
+ Hits          12373      12382         +9     
- Misses         6777       6829        +52     
- Partials       1120       1123         +3     
Flag Coverage Δ *Carryforward flag
br 60.4647% <ø> (ø) Carriedforward from 272a0eb
cdc 61.0903% <0.0000%> (-0.2172%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
cdc/cdc/kv/client.go 83.8616% <ø> (-2.1614%) ⬇️
cdc/cdc/model/kv.go 87.5000% <ø> (ø)
cdc/pkg/api/internal/rest/request.go 70.0000% <ø> (ø)
cdc/pkg/cmd/cli/cli_changefeed_create.go 20.6349% <0.0000%> (ø)
cdc/pkg/db/pebble.go 89.5161% <ø> (ø)
cdc/pkg/etcd/etcd.go 51.9519% <ø> (ø)
cdc/pkg/quotes/quotes.go 100.0000% <ø> (ø)
cdc/pkg/util/overlap_merge.go 98.0769% <ø> (ø)
cdc/pkg/retry/retry_with_opt.go 90.9090% <0.0000%> (-4.5455%) ⬇️
cdc/cdc/sorter/unified/heap_sorter.go 84.1836% <0.0000%> (-3.0613%) ⬇️
... and 9 more

Signed-off-by: Ping Yu <[email protected]>
@pingyu pingyu changed the title *: upgrade to go1.19 & client-go 2.0.5 [close #338] *: upgrade to Go 1.19 Feb 18, 2023
@pingyu pingyu closed this Feb 18, 2023
@pingyu pingyu reopened this Feb 18, 2023
Signed-off-by: Ping Yu <[email protected]>
@pingyu pingyu marked this pull request as ready for review February 18, 2023 23:22
Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.19
3 participants