Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #267] Fix restore ratelimit #268

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

haojinming
Copy link
Contributor

Signed-off-by: haojinming [email protected]

What problem does this PR solve?

Issue Number: close #267

Problem Description:

What is changed and how does it work?

Restore does not send SetDownloadSpeedLimitRequest.

Code changes

  • Has exported function/method change

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • No side effects

Related changes

  • No related changes

Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
@haojinming haojinming requested review from zeminzhou and pingyu and removed request for zeminzhou October 20, 2022 03:36
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #268 (681e667) into main (15b806d) will decrease coverage by 6.2421%.
The diff coverage is 61.7647%.

❗ Current head 681e667 differs from pull request most recent head 459b35d. Consider uploading reports for the commit 459b35d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #268        +/-   ##
================================================
- Coverage   60.9780%   54.7359%   -6.2422%     
================================================
  Files           239        238         -1     
  Lines         20204      20144        -60     
================================================
- Hits          12320      11026      -1294     
- Misses         6766       8074      +1308     
+ Partials       1118       1044        -74     
Flag Coverage Δ *Carryforward flag
br 40.1112% <63.3333%> (-19.9833%) ⬇️
cdc 61.3834% <50.0000%> (ø) Carriedforward from 459b35d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
cdc/cdc/processor/pipeline/sink.go 63.0434% <50.0000%> (ø)
br/pkg/restore/client.go 61.3953% <59.2592%> (+2.3044%) ⬆️
br/pkg/restore/import.go 54.0000% <100.0000%> (+2.5049%) ⬆️
br/pkg/task/restore_raw.go 64.4444% <100.0000%> (ø)
br/pkg/version/version.go 4.8780% <0.0000%> (-78.0488%) ⬇️
br/pkg/storage/parse.go 9.9099% <0.0000%> (-77.4775%) ⬇️
br/pkg/utils/retry.go 14.2857% <0.0000%> (-76.1905%) ⬇️
br/pkg/utils/math.go 0.0000% <0.0000%> (-72.4138%) ⬇️
br/pkg/utils/json.go 0.0000% <0.0000%> (-65.3062%) ⬇️
br/pkg/trace/tracing.go 0.0000% <0.0000%> (-62.5000%) ⬇️
... and 34 more

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@pingyu pingyu merged commit f51cb3d into tikv:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiKV BR restore ratelimit does not work as expected.
3 participants