Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #263] Fix br docker build #264

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented Oct 17, 2022

Signed-off-by: haojinming [email protected]

What problem does this PR solve?

Issue Number: close #263

Problem Description:

What is changed and how does it work?

Fix br docker build

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Manual test (add detailed scripts or steps below)

image

Side effects

  • No side effects

Related changes

  • No related changes

Signed-off-by: haojinming <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #264 (f87545a) into main (92c5d1c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main       #264   +/-   ##
===========================================
  Coverage   61.0176%   61.0176%           
===========================================
  Files           239        239           
  Lines         20204      20204           
===========================================
  Hits          12328      12328           
  Misses         6759       6759           
  Partials       1117       1117           
Flag Coverage Δ *Carryforward flag
br 60.2203% <ø> (ø)
cdc 61.3834% <ø> (ø) Carriedforward from 92c5d1c

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@pingyu pingyu merged commit 15b806d into tikv:main Oct 18, 2022
@haojinming haojinming deleted the br_docoker_build branch October 18, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BR docker image builder
3 participants