[close #229] Add integration test coverage report for TiKV-BR #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
================================================
+ Coverage 54.4026% 60.9804% +6.5777%
================================================
Files 236 238 +2
Lines 20181 20195 +14
================================================
+ Hits 10979 12315 +1336
+ Misses 8328 6758 -1570
- Partials 874 1122 +248
*This pull request uses carry forward flags. Click here to find out more.
|
pingyu
reviewed
Sep 19, 2022
br/tests/rawkv/main.go
Outdated
| @@ -201,7 +206,11 @@ func (t *RawKVBRTester) InjectFailpoint(failpoint string) error { | |||
|
|
|||
| func (t *RawKVBRTester) ExecBRCmd(ctx context.Context, cmdStr string) ([]byte, error) { | |||
| log.Info("exec br cmd", zap.String("br", t.br), zap.String("args", cmdStr)) | |||
| cmd := exec.CommandContext(ctx, t.br, strings.Split(cmdStr, " ")...) | |||
| cmdParameter := []string{fmt.Sprintf("-test.coverprofile=%s_%s_%d", *coverageFile, t.name, t.runCnt)} | |||
There was a problem hiding this comment.
How about just create a unique temporary file (see os.CreateTemp) for the coverage ? Then we don't need the case name & run count.
(If use temporary file, it may need to clear the coverage output path before running test)
There was a problem hiding this comment.
It looks better. I have changed to temp file for coverage file. PTAL~
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #229
Problem Description:
What is changed and how does it work?
Add integration test coverage report for TiKV-BR
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
coverage files are generated as followings:
Side effects
Related changes