Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #213] TiKV-CDC Chinese manual #214

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Aug 25, 2022

Signed-off-by: pingyu [email protected]

What problem does this PR solve?

Issue Number: close #213

Problem Description: Request Chinese manual for China customers

What is changed and how does it work?

Add TiKV-CDC Chinese manual

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • No code

Side effects

  • No side effects

Related changes

  • No related changes

Signed-off-by: pingyu <[email protected]>
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #214 (8311369) into main (9db0b3b) will decrease coverage by 0.1231%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #214        +/-   ##
================================================
- Coverage   61.4599%   61.3368%   -0.1232%     
================================================
  Files           170        170                
  Lines         13809      13809                
================================================
- Hits           8487       8470        -17     
- Misses         4696       4710        +14     
- Partials        626        629         +3     
Flag Coverage Δ
cdc 61.3368% <ø> (-0.1232%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdc/pkg/pdtime/acquirer.go 58.1395% <0.0000%> (-6.9768%) ⬇️
cdc/cdc/kv/client.go 84.8703% <0.0000%> (-1.2969%) ⬇️
cdc/pkg/orchestrator/etcd_worker.go 77.3109% <0.0000%> (-1.2606%) ⬇️
cdc/cdc/kv/region_worker.go 78.7500% <0.0000%> (-0.8334%) ⬇️
cdc/cdc/sorter/unified/unified_sorter.go 91.6666% <0.0000%> (-0.6945%) ⬇️
cdc/cdc/kv/token_region.go 93.7500% <0.0000%> (+3.7500%) ⬆️

Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

cdc/manual-cn.md Outdated Show resolved Hide resolved
cdc/manual-cn.md Outdated Show resolved Hide resolved
Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingyu pingyu merged commit 8cf6529 into tikv:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: Request Chinese manual for China customers.
3 participants