Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #211] add config templates #212

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Aug 24, 2022

Signed-off-by: pingyu [email protected]

What problem does this PR solve?

Issue Number: close #211

Problem Description: Add config templates for TiUP

What is changed and how does it work?

Code changes

  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • No code

Side effects

  • No side effects

Related changes

  • No related changes

Signed-off-by: pingyu <[email protected]>
Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #212 (cfd42f4) into main (1cb59c9) will increase coverage by 0.2679%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #212        +/-   ##
================================================
+ Coverage   61.4599%   61.7278%   +0.2679%     
================================================
  Files           170        170                
  Lines         13809      13809                
================================================
+ Hits           8487       8524        +37     
+ Misses         4703       4638        -65     
- Partials        619        647        +28     
Flag Coverage Δ
cdc 61.7278% <ø> (+0.2679%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdc/pkg/pdtime/acquirer.go 58.1395% <0.0000%> (-6.9768%) ⬇️
cdc/cdc/sink/buffer_sink.go 80.0000% <0.0000%> (-1.8182%) ⬇️
cdc/pkg/orchestrator/etcd_worker.go 78.5714% <0.0000%> (-1.6807%) ⬇️
cdc/cdc/sorter/unified/heap_sorter.go 84.1836% <0.0000%> (-1.5307%) ⬇️
cdc/cdc/processor/processor.go 64.7783% <0.0000%> (-0.7390%) ⬇️
cdc/cdc/kv/client.go 86.0230% <0.0000%> (+0.8645%) ⬆️
cdc/cdc/sorter/unified/file_backend.go 53.9473% <0.0000%> (+20.1754%) ⬆️

@pingyu pingyu merged commit 9db0b3b into tikv:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: Add config templates of TiUP
3 participants