[close #108] Br debug checksum cmd #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haojinming <[email protected]>
Signed-off-by: haojinming <[email protected]> add warning Signed-off-by: haojinming <[email protected]> revert changes Signed-off-by: haojinming <[email protected]>
pingyu
reviewed
Jun 9, 2022
br/pkg/restore/client.go
Outdated
| @@ -64,12 +67,17 @@ func NewRestoreClient( | |||
| keepaliveConf keepalive.ClientParameters, | |||
| isRawKv bool, | |||
| ) (*Client, error) { | |||
| apiVerion, err := backup.GetTiKVApiVersion(context.Background(), pdClient, tlsConf) | |||
There was a problem hiding this comment.
It's a little strange to use a method from backup in restore procedure. It would be better to move GetTiKVApiVersion as a common method.
There was a problem hiding this comment.
moved to common conn package, thanks for the good suggestion.
br/pkg/task/backup_raw.go
Outdated
| @@ -58,10 +58,10 @@ func DefineRawBackupFlags(command *cobra.Command) { | |||
| } | |||
|
|
|||
| // CalcChecksumFromBackupMeta read the backup meta and return Checksum | |||
| func CalcChecksumFromBackupMeta(ctx context.Context, curAPIVersion kvrpcpb.APIVersion, cfg *Config) (checksum.Checksum, []*utils.KeyRange, error) { | |||
| func CalcChecksumFromBackupMeta(ctx context.Context, curAPIVersion kvrpcpb.APIVersion, cfg *Config) (*backuppb.BackupMeta, checksum.Checksum, []*utils.KeyRange, error) { | |||
There was a problem hiding this comment.
Nit: maybe better to get backupMeta outside then pass in here. As what "CalcChecksumFromBackupMeta" says.
Signed-off-by: haojinming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #108
Problem Description:
Checksum maybe mismatch if data expired during backup/restore.
What is changed and how does it work?
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes