Skip to content

cdc: No go generated in building and testing process #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pingyu opened this issue Dec 31, 2023 · 0 comments · Fixed by #379
Closed

cdc: No go generated in building and testing process #378

pingyu opened this issue Dec 31, 2023 · 0 comments · Fixed by #379
Labels
type/bug Something isn't working

Comments

@pingyu
Copy link
Collaborator

pingyu commented Dec 31, 2023

Bug Report

1. Describe the bug

There is no go generate when building and testing. When related codes are edit, the generated codes are not changed accordingly (see #194).

2. Minimal reproduce step (Required)

3. What did you see instead (Required)

4. What did you expect to see? (Required)

5. What is your migration tool and TiKV version? (Required)

  • TiKV: N/A
  • TiKV CDC: master
  • TiKV BR: N/A
  • TiKV Online Bulk Load: N/A
@pingyu pingyu added the type/bug Something isn't working label Dec 31, 2023
@pingyu pingyu mentioned this issue Dec 31, 2023
Merged
pingyu added a commit that referenced this issue Jan 2, 2024
@pingyu
[close #378] *: add go:generate to building and testing process (#379)
c1d7530 
* add go:generate

Signed-off-by: Ping Yu <[email protected]>

* add tools/Makefile

Signed-off-by: Ping Yu <[email protected]>

* fix build error

Signed-off-by: Ping Yu <[email protected]>

---------

Signed-off-by: Ping Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[close #378] *: add go:generate to building and testing process pingyu/tikv-migration
1 participant
@pingyu