Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: OOM happend when create 20 changefeed #241

Closed
zeminzhou opened this issue Sep 28, 2022 · 0 comments · Fixed by #242
Closed

cdc: OOM happend when create 20 changefeed #241

zeminzhou opened this issue Sep 28, 2022 · 0 comments · Fixed by #242
Labels
type/bug Something isn't working

Comments

@zeminzhou
Copy link
Contributor

Bug Report

1. Describe the bug

OOM happend when create 20 changefeed

2. Minimal reproduce step (Required)

  1. start up upstream tikv & tikv-cdc & downstream tikv;
  2. craete 20 chagnefeeds;
  3. input data into upstream tikv;
  4. OOM happened

3. What did you see instead (Required)

  1. OOM happened

4. What did you expect to see? (Required)

  1. No errer happened

5. What is your migration tool and TiKV version? (Required)

  • TiKV CDC:
@zeminzhou zeminzhou added the type/bug Something isn't working label Sep 28, 2022
@zeminzhou zeminzhou changed the title [CDC] OOM happend when create 20 changefeed cdc: OOM happend when create 20 changefeed Sep 28, 2022
@zeminzhou zeminzhou mentioned this issue Sep 28, 2022
Merged
pingyu pushed a commit that referenced this issue Oct 11, 2022
@zeminzhou
[fix #241] fix flow control (#242)
21754a5 
* fix flow control

Signed-off-by: zeminzhou <[email protected]>

* remove barrier

Signed-off-by: zeminzhou <[email protected]>

* KeySpanFlowController -> ChangefeedFlowController

Signed-off-by: zeminzhou <[email protected]>

* fix ut

Signed-off-by: zeminzhou <[email protected]>

* fix ut

Signed-off-by: zeminzhou <[email protected]>

* rename NewKeySpanMemoryQuota -> NewChangefeedMemoryQuota

Signed-off-by: zeminzhou <[email protected]>

* fix ut

Signed-off-by: zeminzhou <[email protected]>

* fix ut

Signed-off-by: zeminzhou <[email protected]>

* fix metric for flow-control

Signed-off-by: zeminzhou <[email protected]>

* fix metric for flow-control

Signed-off-by: zeminzhou <[email protected]>

* add metric for flowController consume

Signed-off-by: zeminzhou <[email protected]>

* fix comment

Signed-off-by: zeminzhou <[email protected]>

* fix comment

Signed-off-by: zeminzhou <[email protected]>

Signed-off-by: zeminzhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix #241] fix flow control zeminzhou/migration
1 participant
@zeminzhou