Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jemalloc to 5.3.0 #23

Merged
merged 15 commits into from
May 13, 2022
Merged

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Apr 13, 2022

systest crate is removed as ctest is not maintained and broken with latest compiler. Giving that API of jemalloc is so simple and stable, I assume it's OK to just not test it anymore.

jemallocator is also moved to subdirectory, so the root directory becomes a pure workspace.

BusyJay added 5 commits April 13, 2022 23:35
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
@BusyJay BusyJay force-pushed the update-to-jemalloc-5.3 branch from 6083b46 to ae68073 Compare April 13, 2022 17:59
@fbernier
Copy link

fbernier commented May 6, 2022

5.3.0 is now officially released: https://github.com/jemalloc/jemalloc/releases/tag/5.3.0

Signed-off-by: Jay Lee <[email protected]>
@BusyJay BusyJay changed the title update jemalloc to 5.3.0-rc update jemalloc to 5.3.0 May 11, 2022
@BusyJay BusyJay requested a review from sticnarf May 11, 2022 16:52
Signed-off-by: Jay Lee <[email protected]>
README.md Outdated
@@ -30,7 +30,7 @@ To use `jemallocator` add it as a dependency:
[dependencies]

[target.'cfg(not(target_env = "msvc"))'.dependencies]
jemallocator = "0.4.0"
jemallocator = "0.5.0-rc"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating jemalloc, we only update the patch version of jemallocator. So, we should make it unchanged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of jemalloc-sys should also be changed. And there are API changes, so minor version should be changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the change, and it will be updated when bumping versions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see.

Copy link

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest lgtm

Signed-off-by: Jay Lee <[email protected]>
@BusyJay BusyJay merged commit 2ffd08e into tikv:master May 13, 2022
@BusyJay BusyJay deleted the update-to-jemalloc-5.3 branch May 13, 2022 21:19
BusyJay added a commit that referenced this pull request May 19, 2022
bors bot added a commit to nervosnetwork/ckb that referenced this pull request Sep 28, 2022
3575: chore: update jemalloc to 5.3.0 r=zhangsoledad a=zhangsoledad

<!--
Thank you for contributing to nervosnetwork/ckb!

If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two.

PR Title Format:
1. module [, module2, module3]: what's changed
2. *: what's changed
-->

### What is changed and how it works?

> ## 0.5.0 - 2022-05-19
> Update jemalloc to 5.3.0 (tikv/jemallocator#23)


### Related changes

- PR to update `owner/repo`:
- Need to cherry-pick to the release branch

### Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

- Unit test
- Integration test


### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. -->

```release-note
Title Only: Include only the PR title in the release note.
```



Co-authored-by: zhangsoledad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants