-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build script: adjust build for ppcle64 #410
Conversation
Allow whiltelist recursively to get around platform related issues. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
f31a3ad
to
5a930ec
Compare
@@ -762,6 +772,11 @@ fn bindgen_test_layout_grpc_slice_buffer() { | |||
) | |||
); | |||
} | |||
impl ::std::fmt::Debug for grpc_slice_buffer { | |||
fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result { | |||
write ! ( f , "grpc_slice_buffer {{ base_slices: {:?}, slices: {:?}, count: {:?}, capacity: {:?}, length: {:?}, inlined: {:?} }}" , self . base_slices , self . slices , self . count , self . capacity , self . length , self . inlined ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format looks weird.
@@ -288,7 +288,8 @@ fn bindgen_grpc(mut config: bindgen::Builder, file_path: &PathBuf) { | |||
.clang_arg("-xc++") | |||
.clang_arg("-I./grpc/include") | |||
.clang_arg("-std=c++11") | |||
.whitelist_recursively(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it resolve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If recusive
is false, all basic types have to be whitelisted explicitly due to limitation of rust-lang/rust-bindgen#1454.
Allow whitelist recursively to get around platform related issues.