Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build script: adjust build for ppcle64 #410

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Nov 26, 2019

Allow whitelist recursively to get around platform related issues.

Allow whiltelist recursively to get around platform related issues.

Signed-off-by: Jay Lee <[email protected]>
@BusyJay BusyJay added the BugFix PR fixes bugs label Nov 26, 2019
Signed-off-by: Jay Lee <[email protected]>
@@ -762,6 +772,11 @@ fn bindgen_test_layout_grpc_slice_buffer() {
)
);
}
impl ::std::fmt::Debug for grpc_slice_buffer {
fn fmt(&self, f: &mut ::std::fmt::Formatter<'_>) -> ::std::fmt::Result {
write ! ( f , "grpc_slice_buffer {{ base_slices: {:?}, slices: {:?}, count: {:?}, capacity: {:?}, length: {:?}, inlined: {:?} }}" , self . base_slices , self . slices , self . count , self . capacity , self . length , self . inlined )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format looks weird.

@@ -288,7 +288,8 @@ fn bindgen_grpc(mut config: bindgen::Builder, file_path: &PathBuf) {
.clang_arg("-xc++")
.clang_arg("-I./grpc/include")
.clang_arg("-std=c++11")
.whitelist_recursively(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it resolve?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If recusive is false, all basic types have to be whitelisted explicitly due to limitation of rust-lang/rust-bindgen#1454.

@BusyJay BusyJay added Do Not Merge Just for test and removed Do Not Merge Just for test labels Nov 27, 2019
@BusyJay BusyJay merged commit 0c16249 into tikv:master Dec 2, 2019
@BusyJay BusyJay deleted the fix-ppcle64-build branch December 2, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFix PR fixes bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants