lock_resolver: let resolve lock timeout properly #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout Signed-off-by: zyguan <[email protected]>
disksing
approved these changes
Jun 21, 2023
cfzjywxk
reviewed
Jun 26, 2023
| @@ -693,6 +693,7 @@ func (lr *LockResolver) getTxnStatusFromLock(bo *retry.Backoffer, l *Lock, calle | |||
| // success before the primary region. | |||
| if err := bo.Backoff(retry.BoTxnNotFound, err); err != nil { | |||
| logutil.Logger(bo.GetCtx()).Warn("getTxnStatusFromLock backoff fail", zap.Error(err)) | |||
| return TxnStatus{}, err | |||
There was a problem hiding this comment.
I vaguely remember that this was intentionally designed in 4.0 to solve some problems, but I can't recall the details.
@MyonKeminta Do you remember?
There was a problem hiding this comment.
It seems to address some issues with resolving v4.0 optimistic mode, but it has no impact on the current default pessimistic mode. Maybe we still need to look into historical problems.
|
I think it's better to merge PRs affecting critical path with 2-3 approvals. |
iosmanthus
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: disksing <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: Weizhen Wang <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: zyguan <[email protected]> ResolvedTS error just write in debug log (#814) ResolvedTS error just write in debug log (#825) fix ci (#835) fix rpc interceptor data race (#845) resolver: let getTxnStatusFromLock return error when backoff timeout (#847)
iosmanthus
added a commit
that referenced
this pull request
Jun 29, 2023
Co-authored-by: disksing <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: Weizhen Wang <[email protected]> Co-authored-by: you06 <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: zzm <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: crazycs <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: zyguan <[email protected]> ResolvedTS error just write in debug log (#814) ResolvedTS error just write in debug log (#825) fix ci (#835) fix rpc interceptor data race (#845) resolver: let getTxnStatusFromLock return error when backoff timeout (#847)
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
Jun 30, 2023
…eout (tikv#847) Signed-off-by: zyguan <[email protected]> Co-authored-by: disksing <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Jun 30, 2023
…eout (#847) (#861) Signed-off-by: zyguan <[email protected]> Co-authored-by: disksing <[email protected]>
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
Jul 12, 2023
…eout (tikv#847) Signed-off-by: zyguan <[email protected]> Co-authored-by: disksing <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Jul 12, 2023
…eout (#847) (#881) Signed-off-by: zyguan <[email protected]> Co-authored-by: disksing <[email protected]>
zyguan
added a commit
to zyguan/client-go
that referenced
this pull request
Aug 16, 2023
…eout (tikv#847) Signed-off-by: zyguan <[email protected]> Co-authored-by: disksing <[email protected]>
cfzjywxk
pushed a commit
that referenced
this pull request
Aug 16, 2023
…eout (#847) (#947) Signed-off-by: zyguan <[email protected]> Co-authored-by: disksing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix pingcap/tidb#44822 , after this PR tidb can pass the test.