Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility test #463

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix compatibility test #463

merged 1 commit into from
Apr 6, 2022

Conversation

disksing
Copy link
Collaborator

@disksing disksing commented Apr 6, 2022 •
edited
Loading

Signed-off-by: disksing [email protected]

golangci-lint failure relates to golangci/golangci-lint-action#442

@disksing
fix lint
360ed1f 
Signed-off-by: disksing <[email protected]>
@disksing disksing marked this pull request as ready for review April 6, 2022 07:29
@disksing disksing requested review from AndreMouche and sticnarf April 6, 2022 07:30
sticnarf
sticnarf approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndreMouche
AndreMouche approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche AndreMouche merged commit cab40e7 into tikv:master Apr 6, 2022
@disksing disksing deleted the comp branch April 6, 2022 07:38
qidi1 pushed a commit to qidi1/client-go that referenced this pull request Apr 11, 2022
@disksing @qidi1
fix compatibility test (tikv#463)
f346cb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@sticnarf sticnarf sticnarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disksing @AndreMouche @sticnarf