Skip to content

Conversation

@gavinxgu
Copy link
Contributor

@gavinxgu gavinxgu commented Jun 8, 2025

#37

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2025

CLA assistant check
All committers have signed the CLA.

@gavinxgu
Copy link
Contributor Author

gavinxgu commented Jun 8, 2025

@octogonz I've added pnpm v9 support to pnpm-sync. Could you provide some guidance on how to write tests for this feature?

@octogonz
Copy link
Member

octogonz commented Jun 8, 2025

Awesome, thanks! 🥳

@octogonz
Copy link
Member

octogonz commented Jun 8, 2025

Could you increase the version number for both pnpm-sync and pnpm-sync-lib to both be 0.3.0? We'll publish a release after the PR is merged.

(They should be lockstepped, because pnpm-sync has a fixed version dependency.)

@gavinxgu
Copy link
Contributor Author

gavinxgu commented Jun 9, 2025

Could you increase the version number for both pnpm-sync and pnpm-sync-lib to both be 0.3.0? We'll publish a release after the PR is merged.

(They should be lockstepped, because pnpm-sync has a fixed version dependency.)

pnpm-sync-lib is now at version 0.3.0, and pnpm-sync is at 0.2.9. If I use version 0.3.0 of pnpm-sync-lib, it will conflict with the remote version on npm. Should I upgrade to version 0.3.1 or 0.4.0 instead?

@octogonz
Copy link
Member

octogonz commented Jun 9, 2025

0.3.1 looks good 👍

@octogonz octogonz merged commit e81dbdf into tiktok:main Jun 9, 2025
2 checks passed
@octogonz
Copy link
Member

octogonz commented Jun 9, 2025

The packages have been published 🚀

@octogonz
Copy link
Member

octogonz commented Jun 9, 2025

BTW I will have to think about a good way to do automated testing for this project. Maybe we can look at how PNPM does it.

@gavinxgu
Copy link
Contributor Author

gavinxgu commented Jun 9, 2025

How about we first merge #41 to ensure the current logic is correct, and then we can provide more comprehensive tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants