-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install with setuptools 58 - "error in jsmin setup command: use_2to3 is invalid." #33
Comments
I'm no longer maintaining this project. Thanks for the workaround pinning setuptools! I'll leave this issue open so that anyone else with the same problem can find it. |
see tikitu/jsmin#33 Signed-off-by: Nicolas MASSART <[email protected]>
* update genesis file content Signed-off-by: Alexandra Tran <[email protected]> * remove minify because of bug see tikitu/jsmin#33 Signed-off-by: Nicolas MASSART <[email protected]> Co-authored-by: Nicolas MASSART <[email protected]>
Faced the same issue. Thanks for providing the workaround, which works fine here as well. |
+ as of tikitu/jsmin#33 + and to match our servers Python version
* Update VM image downloads and complement RPi variants * Fix jsmin build and use Python 3.9.7 as of tikitu/jsmin#33 and to match our servers Python version * Complement wordlist
While locking setup tools is a temporary solution, it will make using this project essentially dead in the future. It probably wouldn't be a bad idea at least to run the conversion from 2to3 on the project and just cut a new Python 3 only release (Python 2 is dead, and the last version can still be used for it). It would at least give this project some more longevity until/if someone wants to help with maintainership. |
If it would be merged, I would be willing to create a pull to get a Python3 only release out the door. But if pulls will not be merged, I won't bother. Please let me know if a pull would be considered. |
Agreed! While its good somehow to have that build failure as last shot call to switch to a different maintained JavaScript minifier, it would be good to have more time (without frozen setuptools) for this migration to bubble up dependency tails.
and if a new release to PyPI can be done accordingly to have pip pulling that fix. |
Ok, I've added #34 to remove Python 2 support. My testing was not exhaustive, but it was a pretty small change and it worked fine for me on Python 3.6.9. |
Any news about this pull request? |
Just read what is actually told in the pull request 😄:
|
Thanks for releasing this @tikitu! |
You're welcome, thanks for making it so easy for me to do so! |
Release is on PyPI: https://pypi.org/project/jsmin/ Many thanks 👍! |
tikitu/jsmin#33 Caused by the release of setuptools 58 on Sep 5 2021, which is not version controlled when brought into the Dockerfile via pip install --upgrade setuptools which lead to builds failing without code changes.
Related to: tikitu/jsmin#33
- It appears to be unused and the upstream project is seemingly unmaintained - It also blocks installs when using versions of setuptools > 57.5.0 due to the same issue described in: tikitu/jsmin#33
- It appears to be unused and the upstream project is seemingly unmaintained - It also blocks installs when using versions of setuptools > 57.5.0 due to the same issue described in: tikitu/jsmin#33
Version 2.2.2 is not longer compatible with setuptools due to use of 2to3. Version 3.0.0 removes support of Python 2. See tikitu/jsmin#33 for more details.
… setuptools>=58 r=jcristau tikitu/jsmin#33 Differential Revision: https://phabricator.services.mozilla.com/D150968
… setuptools>=58 r=jcristau tikitu/jsmin#33 Differential Revision: https://phabricator.services.mozilla.com/D150968
Applies to GOOEY and setuptools. ... |
… setuptools>=58 r=jcristau tikitu/jsmin#33 Differential Revision: https://phabricator.services.mozilla.com/D150968
… setuptools>=58 r=jcristau tikitu/jsmin#33 Differential Revision: https://phabricator.services.mozilla.com/D150968
… setuptools>=58 r=jcristau tikitu/jsmin#33 Differential Revision: https://phabricator.services.mozilla.com/D150968
… setuptools>=58 r=jcristau tikitu/jsmin#33 Differential Revision: https://phabricator.services.mozilla.com/D150968
tikitu/jsmin#33 Caused by the release of setuptools 58 on Sep 5 2021, which is not version controlled when brought into the Dockerfile via pip install --upgrade setuptools which lead to builds failing without code changes.
When trying to install jsmin 2.2.2 from a
requirements.txt
file using a python environment with setuptools 58 the following failure is happening for us on centos:This looks to be happening because setuptools 58 added a breaking change to remove use_2to3 support: https://setuptools.readthedocs.io/en/latest/history.html#v58-0-0
pypa/setuptools#2769
It would be awesome if this could be updated, but until then, if you're also getting this issue, try setuptools 57.5.0.
The text was updated successfully, but these errors were encountered: