Set excludeMediaQueries to true as default #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think including the mediaqueries in the inline-styles is a bit counter-intuitive, as they don't really belong inline.
This was referenced Jul 26, 2014
Closed
tijsverkoyen
added a commit
that referenced
this pull request
Jul 31, 2014
Set excludeMediaQueries to true as default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think including the mediaqueries in the inline-styles is a bit counter-intuitive, as they don't really belong inline.
This didn't really matter before #52 as they weren't processed properly (I think?) but after that change, it kind of messes up the layout. With Zurb Ink, in 1.2.x the flag doesn't have any effect. In 1.5.x, it only works correctly when media queries are excluded. So as this may look like a breaking change, imho the change in #52 broke this behaviour and this change is more 'reasonable'.
(Split of #54 for just this issue)