Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written some basic unit tests, as I've been looking into using HHVM for some projects and wanted to verify basic operation.
For code coverage, I didn't cover excluding/not excluding media queries as it didn't seem to do anything either way. It seems like the CssSelector to XPath converter doesn't support media queries. The formatting changes to the specificity chunk loop were made because it was confusing the code coverage analyser. Aside from that, there is full superficial code coverage.
The library was fully compatible as-is with HHVM 3.1, except for an inconsistency in the uksort, so I made the sort function compatible. See facebook/hhvm#1781