Reuse the same CssSelectorConverter #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing the CSS converter is a bit heavy. Reusing the same instance for all rules instead of creating a new one each time leads to a major performance boost (-20% time spent when running the example). This optimization is possible only when using the Symfony CssSelector component 2.8+. The old API from Symfony 2.7 and older does not allow to perform it, as it exposes only a static method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the CSS converter is a bit heavy. Reusing the same instance for all rules instead of creating a new one each time leads to a major performance boost (-20% time spent when running the example).
This optimization is possible only when using the Symfony CssSelector component 2.8+. The old API from Symfony 2.7 and older does not allow to perform it, as it exposes only a static method.