Docker bug fix #267
Docker bug fix #267
Conversation
Docker access net bug due to buggy Go compiler package fix. Unless docker is used this will not cause longer build time. Signed-off-by: Emrah Billur <[email protected]> _ fix Signed-off-by: Emrah Billur <[email protected]>
emrahbillur
force-pushed
the
docker-fix
branch
from
ab13c65 to
a489e51
Compare
|
Note: Unless docker is enabled this fix will not cause extra build time. |
|
Do we really need this? This says backport has been merged to NixOS 23.05 and it has already hit channel few months ago: |
Of course there's slight possibility it still wasn't on the channel 9 days after the merge which happened 2023-07-19. But it should be at least now |
mikatammi
left a comment
mikatammi
left a comment
There was a problem hiding this comment.
Please double check the need, after the flake input has now been updated
Of course. This was just a temporary fix to be removed till it was on the channel. Since it was an issue with the Go compiler, this PR was just to notify other packages that may be affected by this issue. Otherwise it was to be removed in near future. |
|
Tested with new nixpkgs. Now not needed. Still will be accessed through closed PR's who need Go bug related backport fix. |
3 participants
This is added to resolve the issue https://ssrc.atlassian.net/browse/SP-2697 where originated from NixOS/nixpkgs#244159. We can describe this bug as while running docker containers got a http: invalid Host header
response failing to run.
This is due to a bug in Go package in NixOS where the previous package solves this issue. Same solution can be applied Go compiler related net access bugs till next NixOS release.
When moving to NixOS 23.11, this fix will be removed as it is already fixed in the unstable channel.