Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SL translations #363

Closed
wants to merge 12 commits into from
Closed

Improve SL translations #363

wants to merge 12 commits into from

Conversation

urbanrotnik
Copy link

Add missing SL translations and improve existing translations.

@JasonBarnabe
Update homepage and URL to org
6d35059
@JasonBarnabe
Adjust plural forms so that Transifex is OK with them
3f9f8dd 
It doesn't like when a key with plural forms in English doesn't have that in other languages, so duplicate the existing translations into all forms for the language.
@JasonBarnabe
Add Transifex config file
c7a69ce
@JasonBarnabe
Pull from Transifex
145fbe0 
Content was not updated since the initial push, so this is just quotation, whitespace, etc changes
@JasonBarnabe
Undo Transifex's top-level hyphen to dash change, add missing plural …
58e3a33 
…forms
@JasonBarnabe
Another sync from Transifex
9bed2a3 
Trying to satisfy both Transifex and tests
@JasonBarnabe
Get tests passing again
b0db02f 
- Include rails-i18n as a dependency. This provides pluralization rule information.
- Make the test app more real, running railties.
- Undo some changes for locale plural forms so tests pass again
@urbanrotnik urbanrotnik force-pushed the improve-sl-translations branch 4 times, most recently from b5c152e to 8772db7 Compare October 30, 2024 19:54
@JasonBarnabe
Update i18n gem
6c73d28
@JasonBarnabe
Update from Transifex
e080d02 
This updates many locales with Transifex's pluralization rules, which seem to be more correct than the ones on localeapp, cross-referenced from https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html
@JasonBarnabe
Add script to pull locales from Transifex
a3e5696 
Uses the official Transifex CLI, but also does some post-processing to change locale names in each file from underscores to dashes.
@JasonBarnabe
Copy link
Collaborator

JasonBarnabe commented Oct 30, 2024 •
edited
Loading

Thanks for this. Two things:

  1. According to this, Slovenian's pluralization rules are that there should be one, two, few, and other keys. You can see an example for the not_saved key. Can you add the missing plural forms for the translations you're adding - user and minimum_password_length?
  2. This project is in the middle of getting moved to https://github.com/devise-i18n/devise-i18n. You can create a PR there instead, or you can fix the above issue and I'll port it over, or you can make your changes with a UI at https://app.transifex.com/devise-i18n/devise-i18n-1/dashboard/

@JasonBarnabe
Remove references to localeapp
f9bc140 
It's shutting down, we're switching to Transifex.
@urbanrotnik urbanrotnik force-pushed the improve-sl-translations branch 2 times, most recently from d97c0a6 to 6724433 Compare November 30, 2024 17:25
@urbanrotnik urbanrotnik force-pushed the improve-sl-translations branch from 6724433 to 2ed9ab6 Compare November 30, 2024 17:35
@urbanrotnik
Copy link
Author

urbanrotnik commented Nov 30, 2024 •
edited
Loading

Thanks for this. Two things:

  1. According to this, Slovenian's pluralization rules are that there should be one, two, few, and other keys. You can see an example for the not_saved key. Can you add the missing plural forms for the translations you're adding - user and minimum_password_length?
  2. This project is in the middle of getting moved to https://github.com/devise-i18n/devise-i18n. You can create a PR there instead, or you can fix the above issue and I'll port it over, or you can make your changes with a UI at https://app.transifex.com/devise-i18n/devise-i18n-1/dashboard/

I got it, thanks.
I added missing plural forms. I am closing this PR. I will open it on devise-18n.

PS: Branch was rebased to master on devise-i18n/devise-i18n repo. PR: devise-i18n#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urbanrotnik @JasonBarnabe