Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make operator create volume for kube-controllers /status/status.json #2324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wouttom
Copy link

@wouttom wouttom commented Dec 5, 2022

Description

BUGFIX:
This commit solves an issue when trying to run the calico-kube-controllers with a read-only root FS.
The container will try to write /status/status.json which is also used for the healthcheck.
Since the rootfs is readonly this write will fail and the pod will never become healthy, causing continuous restarts.

By mapping /status to an emptyDir volume the container can run with readonly rootFS

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022

CLA assistant check
All committers have signed the CLA.

@caseydavenport
Copy link
Member

/sem-approve

@mgleung mgleung modified the milestones: v1.29.0, v1.30.0 Jan 13, 2023
@danudey danudey modified the milestones: v1.30.0, v1.30.1 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants