Adjust kube-controller resource order #1875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rene-dekker
reviewed
Mar 29, 2022
| @@ -238,6 +237,9 @@ func (c *kubeControllersComponent) Objects() ([]client.Object, []client.Object) | |||
| objectsToCreate = append(objectsToCreate, c.controllersPodSecurityPolicy()) | |||
| } | |||
|
|
|||
| // Create deployment after all other resources it depends on have been created | |||
| objectsToCreate = append(objectsToCreate, c.controllersDeployment()) | |||
There was a problem hiding this comment.
Do we want do this for all of our renderers?
There was a problem hiding this comment.
A quick check showed that compliance and intrusion detection may also need to be changed.
|
@tmjd are you still planning on getting this one in? I think it needs some test updates as well to make them pass. |
|
Yes I think this is how we should fix the linked issue. I haven't been able to revisit and change those other controllers where this would be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1870
Description
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.