Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_msgs): add conan recipe #147

Open
wants to merge 1 commit into
base: tier4/universe
Choose a base branch
from

Conversation

ZahraBoroujeni
Copy link

Related Links

autowarefoundation/autoware_msgs#100

If we can make a conan pakages for autoware_msgs, then we can make conan packages also for tier4_autoware_msgs. In this way we can have lib and header file of the packages easier and use them along with ros2 humble docker.

Description

I have added the conanfile.py recipes along with the profile of the docker.

Remarks

Conan still is making extension for ament generators, but we can start making conan packages.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • [ x] Code is properly formatted
  • [ x] Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Zahra Boroujeni <[email protected]>
@ZahraBoroujeni ZahraBoroujeni changed the title Add conan recipe feat(tier4_autoware_msgs): Add conan recipe Sep 12, 2024
@ZahraBoroujeni ZahraBoroujeni changed the title feat(tier4_autoware_msgs): Add conan recipe feat(tier4_autoware_msgs): add conan recipe Sep 12, 2024
@ZahraBoroujeni
Copy link
Author

ZahraBoroujeni commented Sep 12, 2024

conan package for testing:
tier4_perception_msgs.zip

Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the comments on this PR.

@ZahraBoroujeni
Copy link
Author

@yukkysaito yukkysaito
Do you also plan to release the messages in rosfarm ? ros-humble-tier4-perception-msgs
Otherwise as ros-humble-autoware-perception-msgs is avaliable, I can drop its dependencies in conan file and we just make a conan package for tier4-perception-msgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants