Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nebula_ros): add smoke tests #240

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test(nebula_ros): add smoke tests #240

wants to merge 4 commits into from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 27, 2024

PR Type

  • Improvement

Description

Add smoke tests for all sensors: each smoke test launches Nebula with the sensor's default configuration and with launch_hw:=false.

In a later PR, launch_hw:=true should also be included, testing whether Nebula can be terminated when waiting for a connection.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Nov 27, 2024
Signed-off-by: Max SCHMELLER <[email protected]>
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.61%. Comparing base (3d42cd0) to head (58c3d8d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   26.11%   27.61%   +1.49%     
==========================================
  Files         101      101              
  Lines        9212     9031     -181     
  Branches     2211     2016     -195     
==========================================
+ Hits         2406     2494      +88     
+ Misses       6417     6124     -293     
- Partials      389      413      +24     
Flag Coverage Δ
differential 27.61% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant