Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hesai_hw_interface): use new UDP socket implementation #235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Nov 25, 2024

PR Type

  • Improvement

Related Links

Description

⚠️ #231 needs to be merged first ⚠️

Use the new UDP socket introduced in #231 as a drop-in, ASIO-free, transport-driver-free replacement for the old UdpDriver in HesaiHwInterface.

Tested on the 2nd gen bus reference vehicle.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 1.94%. Comparing base (dc69e52) to head (ab9a02d).

Files with missing lines Patch % Lines
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% 17 Missing ⚠️
...ros/include/nebula_ros/hesai/hesai_ros_wrapper.hpp 0.00% 5 Missing ⚠️
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dc69e52) and HEAD (ab9a02d). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (dc69e52) HEAD (ab9a02d)
total 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #235       +/-   ##
==========================================
- Coverage   27.21%   1.94%   -25.28%     
==========================================
  Files         104      91       -13     
  Lines        9458    8184     -1274     
  Branches     2322    1051     -1271     
==========================================
- Hits         2574     159     -2415     
- Misses       6449    7971     +1522     
+ Partials      435      54      -381     
Flag Coverage Δ
differential 1.94% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex changed the title Feat/hesai new udp socket feat(hesai_hw_interface): use new UDP socket implementation Nov 25, 2024
mojomex added a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Max SCHMELLER <[email protected]>
mojomex added a commit that referenced this pull request Nov 26, 2024
Signed-off-by: Max SCHMELLER <[email protected]>
@mojomex mojomex force-pushed the feat/hesai-new-udp-socket branch from 91b7e0e to 4619c06 Compare December 2, 2024 07:34
@mojomex mojomex force-pushed the feat/hesai-new-udp-socket branch from 4619c06 to bb1e8e7 Compare December 23, 2024 08:58
@mojomex mojomex force-pushed the feat/hesai-new-udp-socket branch from edccdbb to ab9a02d Compare December 24, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant