-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(default_adapi): subscribe planning factor #1734
fix(default_adapi): subscribe planning factor #1734
Conversation
Signed-off-by: satoshi-ota <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The velocity/steering factor has a status, but planning factor does not. The status of velocity factor will be automatically completed. However, the status of steering factor will not be assigned.
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Thanks for your comment. You're right. I fixed logic in 5d55a4b to fill status automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <[email protected]>
55ffc57
into
feat/development-branch-planning-factor
Quality Gate passedIssues Measures |
Description
New factor msgs were defined in tier4/tier4_autoware_msgs#155 to output various information of module running state. And, each planning module will use them.
In this PR, I fixed adapi node to convert msg type from
tier4_planning_msgs/PlanningFactorArray
toautoware_adapi_v1_msgs/VelocityFactorArray(SteeringFactorArray)
.Related links
Parent Issue:
How was this PR tested?
/api/planning/velocity_factors
by echo command.Notes for reviewers
None.
Interface changes
/planing/planning_factors/xxx
tier4_planning_msgs/PlanningFactorArray
/planing/velocity(steering)_factors/xxx
autoware_adapi_v1_msgs/VelocityFactorArray(SteeringFactorArray)
Effects on system behavior
None.