Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object_lanelet_filter): add velocity direction based object lanelet filter #1315

Open
wants to merge 2 commits into
base: beta/v0.11.2
Choose a base branch
from

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Jun 3, 2024

Description

小松でRadar誤検知により急停止する課題の対処PRです。

Fix radar reverted issue in autowarefoundation#7107 and cherry-pick it.

JIRA ticket is: https://tier4.atlassian.net/browse/RT0-31022?atlOrigin=eyJpIjoiZWU0YjUyZmYxYjNiNGVmZWJlNTg1MWIyNmM0YWMzOGQiLCJwIjoiaiJ9

Related links

入れる対象が古いため、未導入の変更は下記多岐に渡りますが、今回の機能で必要な最初と最後だけをcherry-pickしました。

1b5a6b2190 feat(object_lanelet_filter): add velocity direction based object lanelet filter (#7107)
d4829240bd test(detected_object_validation): add unit tests of utils (#7144)
178841b9cc feat(obstacle_pointcloud_based_validator_node): skip validation when obstacle pointcloud is empty (#6684)
7f36c52fde feat: add published_time publisher debug to packages (#6490)
fc2b2c6046 chore: add maintainer Yoshi Ri to packages (#6552)
724bd80bba chore: update maintainer (#6551)
36b9e9d2f0 chore: update maintainers (#6506)
83f698dd88 feat(perception): add pipeline_latency_ms publisher (#6181)
db637bb8f3 chore(detected_object_validation): rework parameters (#6166)
4cd46880f8 build(detected_object_validation): move header files to a separate directory to avoid conflicts (#5851)
e2d715edaf chore(object_lanelet_filter): add warning comments for large size map handling todo (#5711)
a76d360c33 fix(detected_object_validation): add 3d pointcloud based validator (#5327)
a39b20d952 fix(detected_object_validation): consider shoulder lanelet in object lanelet filter (#5324)

Tests performed

@saka1-s Could you test this PR?

launch PR is here.

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…let filter (autowarefoundation#7107)

* chore: refactor lanelet filter function

Signed-off-by: yoshiri <[email protected]>

* feat: add lanelet direction filter

Signed-off-by: yoshiri <[email protected]>

* fix: do not change default settings

Signed-off-by: yoshiri <[email protected]>

* feat: skip orientation unavailable objects

Signed-off-by: yoshiri <[email protected]>

* fix: feature variable name

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
@YoshiRi YoshiRi requested review from miursh and yukkysaito as code owners June 3, 2024 16:37
@YoshiRi YoshiRi requested a review from saka1-s June 3, 2024 16:39
…lanelet filter (autowarefoundation#5324)

* fix(detected_object_validation): consider shoulder lanelet in object lanelet filter

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: yoshiri <[email protected]>
@YoshiRi
Copy link
Author

YoshiRi commented Jun 7, 2024

@saka1-s 私の手元では動作確認できていますが、今一度時間があるときにsakaiさんの方でも確認していただけると助かります 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants